Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the edit layout interface #373

Closed
jenlampton opened this issue Oct 17, 2014 · 9 comments
Closed

Clean up the edit layout interface #373

jenlampton opened this issue Oct 17, 2014 · 9 comments
Assignees
Labels

Comments

@jenlampton
Copy link
Member

Based on feedback from #86

We need to clean up the edit layout interface, but none of the following issues were important enough to hold up the initial patch.

  1. It's not clear how much of the page is the layout, and how much is just the rest of the admin page. There's a faint gray background on some of the page, but that's not enough. I wonder if adding a solid border around that area of the page might help. (I also think getting rid of stuff that's not part of the layout might also help - the title type selection needs to go!). Here's an attempt at adding a border around the "layout" area. (feedback please!)
    layout-border

  2. The title type selection needs to go. All the other configurations are in modals, so I would love to see the "title" area of the page have a similar configure link, and a modal, where we can hide this title type business. (see screenshot below)

  3. The page title needs to look more like a page title. As it is, it totally gets lost on the page. For starters, it needs to be a H1 instead of a H2. It should probably also be an "area" and not just a string of text, this can be accomplished with a border (and/or a background), like so:
    layout-title

  4. The "add block" buttons are ambiguous as to which region they are adding the block into. Yes, there is a label next to each button, but we don't need to label things, we can just show them. Let's move the labels and buttons inside the region that will hold the block. And add some more spacing. Like so.
    layout-show-region

@ghost
Copy link

ghost commented Oct 17, 2014

I was going to post a similar screenshot suggestion for point 4 above, but then saw yours and yours looks better 😄
Agree to all suggestions.

@Bojhan Bojhan self-assigned this Oct 17, 2014
@Bojhan
Copy link

Bojhan commented Oct 17, 2014

I am going to do some designs for this.

@quicksketch
Copy link
Member

I am going to do some designs for this.

👍

@jenlampton
Copy link
Member Author

I am going to do some designs for this.
👍 👍

@docwilmot
Copy link
Contributor

Any word from @Bojhan on this? Been hoping to see layouts polished and ready!

@Bojhan
Copy link

Bojhan commented Dec 17, 2014

Oops, sorry - I really forget about assigned issues in Github.

I have some time scheduled this weekend to work on it!

@jenlampton
Copy link
Member Author

Thanks @Bojhan, appreciate it!

@klonos
Copy link
Member

klonos commented May 23, 2015

What's left here after #891 ??

@quicksketch
Copy link
Member

I think items 2 and 3 still need to be addressed, both relating to the title configuration. Let's split this out into a dedicated issue: #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants