-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Block visibility conditions: Improve the is/is-not setting for "Front page" condition. #1017
Comments
Good idea. We inherited this "NOT" terminology from porting Panels conditions. |
The PR at backdrop/backdrop#983 makes a start on this but would require us to provide an update hook. Perhaps we can keep the internal representation while only changing the display of the options. |
New PR at backdrop/backdrop#1043. How does this look? |
Absolutely agreed. And the radio button labels are good; maybe "Any page except the frontpage" instead of "every"? |
Good point, I've make that small change in the PR. |
👍 Perfect!! |
...perhaps add something like "Show when" in front of "Current path is". So, full thing should read "Show when current path is:" |
Yeah, I wasn't sure about adding a verb like "Show" onto the form for a condition. Conditions can be used for more things than just hiding or showing. For example, show/hide isn't the right verb when selecting the appropriate layout from multiple layouts at the same path. Rather than "show/hide this block if...", it's "select this layout if...". I hope it's not premature abstraction for terminology, but conditions already can be used for two different purposes. |
Fair enough. |
Great! Merged in backdrop/backdrop#1043. As this is not strictly a bug fix, it will be in 1.2.0 only (and not 1.1.4). |
Here's what the user gets:
What I would like to see in general is the respective second-step config dialog for all options (front page/site language/user permission/user role/URL) to be shown in an JS/AJAX-y way without a second dialog reload, but that's probably another issue (edit: #1020).
WTF is this "Reverse (NOT)"? Lets change this to a radio button that clearly states what the conditions are:
() is front page
() is NOT front page
The text was updated successfully, but these errors were encountered: