Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Block visibility conditions: Improve the is/is-not setting for "Front page" condition. #1017

Closed
klonos opened this issue Jun 21, 2015 · 10 comments

Comments

@klonos
Copy link
Member

klonos commented Jun 21, 2015

Here's what the user gets:

block_config-front_page_condition

What I would like to see in general is the respective second-step config dialog for all options (front page/site language/user permission/user role/URL) to be shown in an JS/AJAX-y way without a second dialog reload, but that's probably another issue (edit: #1020).

WTF is this "Reverse (NOT)"? Lets change this to a radio button that clearly states what the conditions are:

() is front page
() is NOT front page

@quicksketch
Copy link
Member

Good idea. We inherited this "NOT" terminology from porting Panels conditions.

@quicksketch
Copy link
Member

The PR at backdrop/backdrop#983 makes a start on this but would require us to provide an update hook. Perhaps we can keep the internal representation while only changing the display of the options.

@quicksketch
Copy link
Member

New PR at backdrop/backdrop#1043.

How does this look?

screenshot17

@docwilmot
Copy link
Contributor

Perhaps we can keep the internal representation while only changing the display of the options.

Absolutely agreed. And the radio button labels are good; maybe "Any page except the frontpage" instead of "every"?

@quicksketch
Copy link
Member

And the radio button labels are good; maybe "Any page except the frontpage" instead of "every"?

Good point, I've make that small change in the PR.

@quicksketch quicksketch added this to the 1.2.0 milestone Sep 12, 2015
@klonos
Copy link
Member Author

klonos commented Sep 13, 2015

👍 Perfect!!

@klonos
Copy link
Member Author

klonos commented Sep 13, 2015

...perhaps add something like "Show when" in front of "Current path is". So, full thing should read "Show when current path is:"

@quicksketch
Copy link
Member

...perhaps add something like "Show when" in front of "Current path is". So, full thing should read "Show when current path is:"

Yeah, I wasn't sure about adding a verb like "Show" onto the form for a condition. Conditions can be used for more things than just hiding or showing. For example, show/hide isn't the right verb when selecting the appropriate layout from multiple layouts at the same path. Rather than "show/hide this block if...", it's "select this layout if...". I hope it's not premature abstraction for terminology, but conditions already can be used for two different purposes.

@klonos
Copy link
Member Author

klonos commented Sep 13, 2015

Fair enough.

@quicksketch
Copy link
Member

Great! Merged in backdrop/backdrop#1043. As this is not strictly a bug fix, it will be in 1.2.0 only (and not 1.1.4).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants