Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[D8][UX] Multi-value field items should offer some way for individual values to be removed #2917

Closed
klonos opened this issue Dec 8, 2017 · 7 comments

Comments

@klonos
Copy link
Member

klonos commented Dec 8, 2017

This is one of the many, tiny things that has been annoying me in the Drupal (and thus inherently Backdrop) UI for years:

When working on a new Drupal 7 site I noticed a feature from the old D6 CCK days that allows you to remove a single item from a field that has unlimited values. Unfortunately, this is not built into Drupal 7's fields ... In a D7 unlimited field, you 'delete' an item by emptying all of its values and saving the form. This works fine in practice but is highly unintuitive for a standard Drupal user (ie: clients) ...

screen shot 2017-12-08 at 2 33 12 am

There are currently two modules that address this issue:

Multiple Fields Remove Button:

screen shot 2017-12-08 at 2 41 12 am

Field Remove Item:

screen shot 2017-12-08 at 2 55 42 am

Both of these modules work the same, in that once the user clicks on either the button or the checkbox, the entry is removed in an AJAXy way. This action removes the item only from the form; there is no actual removal unless the user saves the form. I think that in our implementation, entries should be "marked" for removal, but still remain visible on the form, giving the user the option to change their mind and undo. Perhaps a list of checkboxes in a "remove" column would be more similar to other places in our UI, and thus a familiar UI pattern for the end user.

@klonos
Copy link
Member Author

klonos commented Dec 8, 2017

There's also a ticket for including this functionality in D8.5 core: https://www.drupal.org/project/drupal/issues/1038316

...last comment there (a few days ago) is talking about using AJAX vs checkboxes too.

I would like to know what people think with regards to what would be the best solution UX-wise. I'm obviously voting for the checkbox, non-AJAX way, because I think that it would be the less complicated and less bug-prone one, plus it would be more straight forward to the user as to what is happening (compared to the removed-from-the-form-changes-not-actually-saved approach that is).

@klonos
Copy link
Member Author

klonos commented Dec 8, 2017

...added this issue to the list in #378

@Graham-72
Copy link

We seem to already have remove buttons for multi-value image fields. How do these work?

@klonos
Copy link
Member Author

klonos commented Apr 22, 2018

...good catch @Graham-72 👍I have tested this with a link field:

screen shot 2018-04-23 at 8 57 55 am

We should adapt/abstract the code used in the image multi-value field, so to work with all multi-value fields.

@klonos
Copy link
Member Author

klonos commented Apr 22, 2018

...I am classifying this as a UX bug.

@klonos klonos changed the title [UX] Add a "remove" button to multi-value field items. [UX] Multi-value field items should offer some way for individual values to be removed.. Apr 22, 2018
@klonos klonos changed the title [UX] Multi-value field items should offer some way for individual values to be removed.. [UX] Multi-value field items should offer some way for individual values to be removed Apr 22, 2018
@jenlampton
Copy link
Member

I use the Multiple Fields Remove Button module often, +1 for this idea from me.

@jenlampton jenlampton changed the title [UX] Multi-value field items should offer some way for individual values to be removed [D8][UX] Multi-value field items should offer some way for individual values to be removed Apr 28, 2019
@klonos klonos self-assigned this Oct 12, 2019
@jenlampton
Copy link
Member

This looks like a duplicate of #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants