Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing v0.12.0 #1031

Merged
merged 16 commits into from
Mar 1, 2019
Merged

Releasing v0.12.0 #1031

merged 16 commits into from
Mar 1, 2019

Conversation

sanathkr
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv self-requested a review February 28, 2019 22:50
sriram-mv
sriram-mv previously approved these changes Feb 28, 2019
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo 🥇

- while testing for custom profiles, make sure environment variables are
  not already set, as it looks like preset environment variables get
  precendence over setting via profiles.
Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Says thanks to all the travis gods in support of this PR.

@sanathkr sanathkr merged commit 7ddb5e4 into master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants