Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integ): Add tests for SAM_* Environment Variables #1019

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Feb 20, 2019

Issue #, if available:
#992

Description of changes:
Added tests for the following SAM Env Vars:

  • SAM_LAYER_CACHE_BASEDIR
  • SAM_SKIP_PULL_IMAGE
  • SAM_TEMPLATE_FILE
  • SAM_DOCKER_NETWORK

Ones not included:

  • SAM_DEBUG
  • SAM_DEBUG_PORT
  • DEBUGGER_ARGS
  • SAM_DOCKER_VOLUME_BASEDIR
  • SAM_FORCE_IMAGE_BUILD

I am happy to add tests for the ones I did not include, but I did not have a good way to test them.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv self-requested a review February 20, 2019 17:32
@sriram-mv
Copy link
Contributor

current tests look good to me.

Copy link
Contributor

@sriram-mv sriram-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


self.test_data_path.joinpath("invoke", "sam-template.yaml")
env = os.environ.copy()
env["SAM_TEMPLATE_FILE"] = str(self.test_data_path.joinpath("invoke", "sam-template.yaml"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@jfuss jfuss merged commit 7b9fe32 into aws:develop Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants