Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): Make template spacing consistent #962

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

jlhood
Copy link
Contributor

@jlhood jlhood commented Jan 25, 2019

Issue #, if available: N/A

Description of changes:
The template indent spacing was inconsistent (sometimes 4 spaces,
sometimes 2). This makes them consistently use 2 spaces. 2 spaces was
chosen, because it's a defacto standard for yaml and also the AWS
Serverless Application Repository has a "Copy as SAM Resource" button,
which copies yaml to your clipboard using 2 spaces.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jlhood and others added 2 commits January 25, 2019 13:10
The template indent spacing was inconsistent (sometimes 4 spaces,
sometimes 2). This makes them consistently use 2 spaces. 2 spaces was
chosen, because it's a defacto standard for yaml and also the AWS
Serverless Application Repository has a "Copy as SAM Resource" button,
which copies yaml to your clipboard using 2 spaces.
Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this consistent!

@jfuss jfuss added stage/accepted Accepted and will be fixed area/init sam init labels Feb 7, 2019
@jlhood jlhood merged commit 0eef8d7 into aws:develop Feb 7, 2019
@jlhood jlhood deleted the template-spacing branch February 7, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init sam init stage/accepted Accepted and will be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants