-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept non-integer statusCode JSON values #1013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add integration tests for this? This will help us make sure changes don't regress behavior in the future.
I've added an integration test in what I think is the right place. I get S3 client errors trying to run those tests locally so we'll see what Travis says. |
@slank Thanks for adding the tests. Some of our integ-tests require creds, so it's could be either you don't have the correct permissions or no credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch 🕺
Description of changes:
The Lambda proxy integration for API Gateway does not specify that statusCode must be an integer, but SAM CLI requires it. This change fixes SAM CLI to accept non-integer status codes that contain integer values.
See slank/awsgi#23 for additional background.
Checklist:
make pr
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.