Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept non-integer statusCode JSON values #1013

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Accept non-integer statusCode JSON values #1013

merged 2 commits into from
Feb 19, 2019

Conversation

slank
Copy link
Contributor

@slank slank commented Feb 15, 2019

Description of changes:

The Lambda proxy integration for API Gateway does not specify that statusCode must be an integer, but SAM CLI requires it. This change fixes SAM CLI to accept non-integer status codes that contain integer values.

See slank/awsgi#23 for additional background.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sanathkr sanathkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add integration tests for this? This will help us make sure changes don't regress behavior in the future.

@slank
Copy link
Contributor Author

slank commented Feb 15, 2019

I've added an integration test in what I think is the right place. I get S3 client errors trying to run those tests locally so we'll see what Travis says.

@jfuss
Copy link
Contributor

jfuss commented Feb 19, 2019

@slank Thanks for adding the tests. Some of our integ-tests require creds, so it's could be either you don't have the correct permissions or no credentials.

Copy link
Contributor

@jfuss jfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants