Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove tests from .whl file (bdist_wheel) #1023

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

jfuss
Copy link
Contributor

@jfuss jfuss commented Feb 25, 2019

Issue #, if available:
N/A

Description of changes:
Python wheels, .whl files, produced through python setup.py bdist_wheel do not read or understand MANIFEST.in files. Since we use this file to remove tests modules from the dists, tests end up in the .whl files that get uploaded to PyPi. This PR updates the exclude parameter in find_packages to exclude all test.* modules, following setuptools documentation.

Checklist:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sriram-mv sriram-mv merged commit ec3097a into aws:develop Feb 28, 2019
@tbradley-sans
Copy link

Hi, I don't totally understand this change, so I'm wondering if it addresses the problem I'm having right now. I just realized that when I do sam build -u somehow some Python unit tests that don't belong to me are getting put into my project's tests directory. They don't have any copyright notices or even code comments (shame, shame) but since they're importing things like serverlessrepo.parser I'm guessing they belong to SAM. True?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants