release: v1.57.0 #6169
Draft
release: v1.57.0 #6169
+3,983
−4,022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts PR #6048 now that rust-lang/rust#130769 is fixed.
Co-authored-by: Renée <[email protected]>
Co-authored-by: Andrew McGivery <[email protected]>
Co-authored-by: Renée <[email protected]>
Co-authored-by: Jesse Rosenberger <[email protected]>
…etween Rust QP and JS QP (#6090)
Co-authored-by: Renée <[email protected]>
…on the same selection (#6120)
The following is now done in `QueryAnalysisLayer` instead of in the `BridgeQueryPlanner` service: * Finding the relevant operation in a GraphQL document based on `operationName`. Now `ParsedDocument` in context contains a reference to the parsed `apollo_compiler::executable::Operation`. * Scan that operation’s root fields to find which are present: root `__typename`, schema intropsection, and "normal" non-meta fields. This is a preliminary step to moving introspection out of `BridgeQueryPlanner`. As a side-effect observable to clients, the exact response for some error cases like an empty document changes slightly as the error no longer comes from JavaScript code. Also drive-by refactor: change `spec::Query` to contain a single `Operation` instead of a `Vec<Operation>`. This removes conditionals and the need to pass `operationName` around in a lot of places, notably in execution code.
Add an Environment variable to the container that's deployed so that we can easily scan if customers are deploying using the official Helm Chart or some other way.
…e same selection (#6137)
…e __typename selections (#6141) - updated sibling typename optimization to only fold a plain __typename without alias/directives. - also, fixed __typename ordering in fetch operations to put the plain __typename ahead of others.
Signed-off-by: Benjamin <[email protected]> Co-authored-by: Andrew McGivery <[email protected]>
Schema introspection now runs natively without involving JavaScript code. We have high confidence that the two implementations return matching responses based on differential testing fuzzing arbitrary queries against a large schema, and testing a corpus of customer schemas against a comprehensive query. In Router YAML configuration: * The `experimental_introspection_mode` key is removed, `new` is now the only behavior * The `supergraph.query_planning.legacy_introspection_caching` key is removed, the behavior is now similar to what was `false`: introspection responses are not part of the query plan cache but instead in a separate, small, in-memory only cache. Migrations ensure that existing configuration files will keep working.
Co-authored-by: Simon Sapin <[email protected]> Co-authored-by: Jesse Rosenberger <[email protected]>
Updates to latest router-bridge and federation version. This federation version: - Fixes a query planning bug where operation variables for a subgraph query wouldn't match what's used in that query. - Fixes a query planning bug where directives applied to `__typename` may be omitted in the subgraph query. - Fixes a query planning inefficiency where some redundant subgraph queries were not removed. - Fixes a query planning inefficiency where some redundant inline fragments in `@key`/`@requires` selection sets were not optimized away. - Fixes a query planning inefficiency where unnecessary subgraph jumps were being added when using `@context`/`@fromContext`.
Co-authored-by: Lucas Leadbetter <[email protected]>
…dd schema id in context (#6160) Signed-off-by: Benjamin <[email protected]>
✅ Docs Preview ReadyNo new or changed pages found. |
|
CI performance tests
|
shorgi
reviewed
Oct 17, 2024
| request_context: "apollo::supergraph_schema_id" # The key containing the supergraph schema id | ||
| ``` | ||
|
|
||
| It can be used in any services at any stages. This example is using selectors on event's attributes but it can also be done on spans and instruments. |
There was a problem hiding this comment.
Suggested change
| It can be used in any services at any stages. This example is using selectors on event's attributes but it can also be done on spans and instruments. | |
| You can use the selector in any service at any stage. While this example applies to `events` attributes, the selector can also be used on spans and instruments. |
| @@ -0,0 +1,21 @@ | |||
| ### Add support of router request_context selector and add schema id in context ([PR #6160](https://github.com/apollographql/router/pull/6160)) | |||
|
|
|||
| Added a new selector `request_context` for the router service for telemetry. Now the supergraph schema id is also available through the context so if you want to access or display this schema id at the router service level you can now configure it like this: | |||
There was a problem hiding this comment.
Suggested change
| Added a new selector `request_context` for the router service for telemetry. Now the supergraph schema id is also available through the context so if you want to access or display this schema id at the router service level you can now configure it like this: | |
| The router supports a new `request_context` selector for telemetry that enables access to the supergraph schema ID. | |
| You can configure the context to access the supergraph schema ID at the router service level: |
| @@ -0,0 +1,21 @@ | |||
| ### Add support of router request_context selector and add schema id in context ([PR #6160](https://github.com/apollographql/router/pull/6160)) | |||
There was a problem hiding this comment.
Suggested change
| ### Add support of router request_context selector and add schema id in context ([PR #6160](https://github.com/apollographql/router/pull/6160)) | |
| ### Support new `request_context` selector for telemetry ([PR #6160](https://github.com/apollographql/router/pull/6160)) |
| @@ -0,0 +1,20 @@ | |||
| ### Support to get/set URI port in Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) | |||
There was a problem hiding this comment.
Suggested change
| ### Support to get/set URI port in Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) | |
| ### Support reading URI port of request in Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) |
There was a problem hiding this comment.
This still reads a bit funny to me — what about:
Suggested change
| ### Support to get/set URI port in Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) | |
| ### Support reading `port` value of request URIs using Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) |
?
| @@ -0,0 +1,20 @@ | |||
| ### Support to get/set URI port in Rhai ([Issue #5437](https://github.com/apollographql/router/issues/5437)) | |||
|
|
|||
| This adds support to read the port from the `request.uri.port`/`request.subgraph.uri.port` functions in Rhai, enabling the ability to update the full URI for subgraph fetches. For example: | |||
There was a problem hiding this comment.
Suggested change
| This adds support to read the port from the `request.uri.port`/`request.subgraph.uri.port` functions in Rhai, enabling the ability to update the full URI for subgraph fetches. For example: | |
| Custom Rhai scripts in the router now support the `request.uri.port` and `request.subgraph.uri.port` functions for reading URI ports. These functions enable you to update the full URI for subgraph fetches. For example: |
| * The `experimental_introspection_mode` key is removed, `new` is now the only behavior | ||
| * The `supergraph.query_planning.legacy_introspection_caching` key is removed, the behavior is now similar to what was `false`: introspection responses are not part of the query plan cache but instead in a separate, small, in-memory only cache. | ||
|
|
||
| Migrations ensure that existing configuration files will keep working. |
There was a problem hiding this comment.
@SimonSapin does this mean the router supports existing config files with these removed keys automatically? Or do users need to do manual migration steps of removing/updating them?
Comment on lines
+1
to
+3
| ### Add uri and method properties on router request in Rhai ([PR #6114](https://github.com/apollographql/router/pull/6114)) | ||
|
|
||
| Previously, when trying to access `request.uri` and `request.method` on a Router Request in Rhai, Router would error saying the properties are undefined. |
There was a problem hiding this comment.
Suggested change
| ### Add uri and method properties on router request in Rhai ([PR #6114](https://github.com/apollographql/router/pull/6114)) | |
| Previously, when trying to access `request.uri` and `request.method` on a Router Request in Rhai, Router would error saying the properties are undefined. | |
| ### Support URI and method properties for router request in Rhai ([PR #6114](https://github.com/apollographql/router/pull/6114)) | |
| The router now supports accessing `request.uri` and `request.method` properties from custom Rhai scripts. | |
| Previously, when trying to access `request.uri` and `request.method` on a router request in Rhai, the router would return error messages stating the properties were undefined. | |
| An example Rhai script using these properties: |
|
|
||
| The router now correctly handles the `__typename` field used on operation root types, even when the subgraph's root type has a name that differs from the supergraph's root type. | ||
|
|
||
| For example, in query like this: |
There was a problem hiding this comment.
Suggested change
| For example, in query like this: | |
| For example, given a query like this: | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch of an upcoming release (version number in the title).main)