Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added telemetry for Rhai usage #6027

Conversation

andrewmcgivery
Copy link
Contributor

Added telemetry for Rhai usage


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@andrewmcgivery andrewmcgivery marked this pull request as ready for review September 18, 2024 16:47
@andrewmcgivery andrewmcgivery requested review from a team as code owners September 18, 2024 16:47
Copy link
Contributor

@BrynCooke BrynCooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add a test? There is an existing test already, you just need to add a config file to src/configuration/testdata/metrics and commit the snapshot.

@abernix abernix changed the base branch from dev to abernix/landing-pad-6027 October 1, 2024 15:36
@abernix abernix merged commit 1c220d4 into apollographql:abernix/landing-pad-6027 Oct 1, 2024
7 of 13 checks passed
abernix added a commit that referenced this pull request Oct 1, 2024
@abernix
Copy link
Member

abernix commented Oct 1, 2024

Tests passed in #6098. This is now merged into dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants