-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added telemetry for Rhai usage #6027
Merged
abernix
merged 8 commits into
apollographql:abernix/landing-pad-6027
from
andrewmcgivery:feature/rhaitelemetry
Oct 1, 2024
Merged
Added telemetry for Rhai usage #6027
abernix
merged 8 commits into
apollographql:abernix/landing-pad-6027
from
andrewmcgivery:feature/rhaitelemetry
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrynCooke
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you add a test? There is an existing test already, you just need to add a config file to src/configuration/testdata/metrics
and commit the snapshot.
BrynCooke
approved these changes
Sep 20, 2024
garypen
approved these changes
Sep 24, 2024
bnjjj
approved these changes
Sep 26, 2024
abernix
merged commit Oct 1, 2024
1c220d4
into
apollographql:abernix/landing-pad-6027
7 of 13 checks passed
abernix
added a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Andrew McGivery <[email protected]>
Tests passed in #6098. This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added telemetry for Rhai usage
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩