fix: make test supergraphs valid

[lennyburdette]

this becomes a problem when switching to the native QP by default

---

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

• Changes are compatible¹
• Documentation² completed
• Performance impact assessed and acceptable
• Tests added and passing³
  • Unit Tests
  • Integration Tests
  • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

[github-actions]

@lennyburdette, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

[router-perf]

CI performance tests

• connectors-const - Connectors stress test that runs with a constant number of users
• const - Basic stress test that runs with a constant number of users
• demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled
• demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
• enhanced-signature - Enhanced signature enabled
• events - Stress test for events with a lot of users and deduplication ENABLED
• events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
• events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
• events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
• events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
• events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
• extended-reference-mode - Extended reference mode enabled
• large-request - Stress test with a 1 MB request payload
• no-tracing - Basic stress test, no tracing
• reload - Reload test over a long period of time at a constant rate of users
• step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
• step-local-metrics - Field stats that are generated from the router rather than FTV1
• step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
• step - Basic stress test that steps up the number of users over time
• xlarge-request - Stress test with 10 MB request payload
• xxlarge-request - Stress test with 100 MB request payload

[goto-bus-stop]

I think it's a little suspicious that Rust doesn't accept those. Could there be customers with such "incomplete" supergraphs? will discuss with the QP team if we shouldn't change the native QP instead

[lennyburdette]

the contract we have with customers is that they should use only federation composition to generate supergraphs — i don't think we need to relax our supergraph validation because our own composition could must always emit valid supergraphs. whether we should, maybe to adhere to the robustness principle, might be a discussion worth having, but i'm not sure.

[goto-bus-stop]

Right. I guess we would've also known by now if any customer does rely on it through all the testing we've done with Rust.

[svc-apollo-docs]

✅ Docs Preview Ready

Configuration

{
  "repoOverrides": {
    "apollographql/router@dev": {
      "remote": {
        "owner": "apollographql",
        "repo": "router",
        "branch": "lb/fix-supergraphs"
      }
    }
  }
}

Name	Link
Commit	917ec0c
Preview	https://www.apollographql.com/docs/deploy-preview/2db836e076cc48da0b1c
Build ID	2db836e076cc48da0b1c
File Changes	0 new, 2 changed, 0 removed * graphos/reference/federation/versions.mdx * graphos/routing/uplink.mdx
Pages	2

---

2 pages published. Build will be available for 30 days.