fix(dual-query-planner): fixed the remaining of coercion mismatches between Rust QP and JS QP #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated vec_matches_as_set to use it.
…S QP - updated the coercion check to recurse into List and Object values. - loosened Object value check to be a inclusion check, instead of empty check
|
@duckki, please consider creating a changeset entry in |
|
CI performance tests
|
| fn test_query_variable_decl_list_value_coercion_empty_case() { | ||
| // Note: Rust QP expands empty list default values by filling in its default items. | ||
| let op_x = r#"query($qv1: [Int!]! = []) { x(arg1: $qv1) }"#; | ||
| let op_y = r#"query($qv1: [Int!]! = [1, 42]) { x(arg1: $qv1) }"#; |
There was a problem hiding this comment.
This seems strange? these are not equivalent queries.
There was a problem hiding this comment.
y is expected to have additional items over x by filling in the (assumed-to-be) default value.
There was a problem hiding this comment.
I'm confused about that. The default value is declared to be [] in one and [1, 42] in the other. This isn't a list that would pull in default values--it's a declaration of a default value.
There was a problem hiding this comment.
For objects, default property values come from the input object definition, but that doesn't exist for lists
There was a problem hiding this comment.
Ah, you are right. We don't have to loosen lists.
goto-bus-stop
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.