Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variable To Helm Chart To Check Usage #6136

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

jonathanrainer
Copy link
Contributor

Add an Environment variable to the container that's deployed so that we can easily scan if customers are deploying using the official Helm Chart or some other way.

Ran this through the templater and it generates correctly so there's little to test beyond that.

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Oct 10, 2024

✅ Docs Preview Ready

No new or changed pages found.

Copy link
Contributor

@jonathanrainer, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Add an Environment variable to the container that's deployed
so that we can easily scan if customers are deploying using
the official Helm Chart or some other way.
@nmoutschen nmoutschen requested a review from a team October 11, 2024 14:48
@jonathanrainer jonathanrainer merged commit fdb1151 into dev Oct 14, 2024
15 checks passed
@jonathanrainer jonathanrainer deleted the jr/task/FLEET-15 branch October 14, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants