Forms validation refactoring

[IgorMinar]

This is a meta issue for refactoring of forms validation in AngularJS.

We are considering to do this in 1.3, but it might slip.

Related/Sub issues:

• when ng-maxlength is invalid, 'require' validation is also invalid #6304 - when ng-maxlength is invalid, 'require' validation is also invalid
• Input number with required validation is broken on chrome #6818 - Input number with required validation is broken on chrome
• ngOptions : regression 1.2.15 && 1.3.0-beta.3 #6828 - ngOptions : regression 1.2.15 && 1.3.0-beta.3
• fix(input): ngMinlength/ngMaxlength should not invalidate non-stringlike values #6002 - Forms validation refactoring
• Forms validation refactoring #6928 - ngMin doesn't render values that are initially invalid

[Narretz]

I jotted down some thoughts about parsers / formatters and validation here: #6740

[plentz]

One more thing that I think could go to 1.3: don't "bubble" the validation of the nested form to the parent form (#5037 #5858 #6095)

[tbosch]

This PR should solve most of the problems: #8267 (although it also adds async validators as new feature).

I quickly went through the list of all open issues that were tagged with component: forms and found the following interesting cases for validation (which are still open):

Validation issues that we really should fix with the new design:

• fix(input): improve html5 validation for ngModelOptions fix(input): improve html5 validation for ngModelOptions #7976
• maxlength issue in 1.3.0 beta 15 (invalid -> valid) maxlength issue in 1.3.0 beta 15 (invalid -> valid) #8234
  • ngMaxLength with integer only input fails ngMaxLength with integer only input fails #7848
  • Dup? Input date throws required when date is invalid Input date throws required when date is invalid #8374
• input[type="date"] validity doesn't change when min/max change input[type="date"] validity doesn't change when min/max change #6755
• "minValidator" does not make sense as a formatter. Input number "min" does not show initial value when it is invalid "minValidator" does not make sense as a formatter. Input number "min" does not show initial value when it is invalid #8264
• Input number with required validation is broken on chrome Input number with required validation is broken on chrome #6818
• Input date throws required when date is invalid Input date throws required when date is invalid #8374
• ng-required conflicts with ng-true-value ng-required conflicts with ng-true-value #5164
  • see fix(input): ng-required conflicts with ng-true-value fix(input): ng-required conflicts with ng-true-value #6065
• select with required and only 1 option fails to validate (and set ng-model) until change event is manually triggered select with required and only 1 option fails to validate (and set ng-model) until change event is manually triggered #6288
• input type='email' doesn't work with ngList input type='email' doesn't work with ngList #4185

Related PRs to think about:

• fix(input): validate minlength/maxlength for non-string values fix(input): validate minlength/maxlength for non-string values #7968
• Adds tel input type validation Adds tel input type validation #7315
• fixed email regexp fixed email regexp #7944
• fix(input[url]): Invalid URLS incorrectly valid fix(input[url]): Invalid URLS incorrectly valid #7816
• bug($ng): change numberInputType to check for leading decimals bug($ng): change numberInputType to check for leading decimals #5682

Related new features to think about:

• Improve support for collections in ngModelController Improve support for collections in ngModelController #7203
• NgModel needs a way to manually re-run the formatter chain NgModel needs a way to manually re-run the formatter chain #3407

[tbosch]

Before we close this issue, we should really do this again: go through the list of all open issues that were tagged with component: forms and solve them / verify them.

Open question: Should be backport the changes (and fixes) to Angular 1.2.x as well? If not, should we leave the issues open for Angular 1.2.x?

[Narretz]

A lot of these have been tackled, but somehow the lists gets longer and longer:

Bugs:

• fix(input): make checkbox ngTrueValue work with required #8979 fix(input): make checkbox ngTrueValue work with required (needs review)
• fix(form): do not prevent submit when action attribute equals to an empty string #3776 do not prevent submit when action attribute equals to an empty string (needs test)
• Inconsistent handling of invalid initial ngModel values: Inconsistent handling of invalid initial ngModel values #8949

Feats:

• Need a way to overwrite the email validate logic Need a way to overwrite the email validate logic. #7798
• feat(ngModelOptions): add allowInvalid option feat(ngModelOptions): add allowInvalid option #8313
• Feature request: Ability to read trigger event for $parsers. Feature request: Ability to read trigger event for $parsers. #8976
• add validateOn to ng-model-options to make the $parsers run even when updates are pending add validateOn to ng-model-options to make the $parsers run even when updates are pending #7016

[tbosch]

@Narretz thanks for the summary!

[IgorMinar]

the remaining issues are #7016 and #8976 - both of these are features not part of the original scope of this change. So I'm closing this meta issue as resolved.