ngMaxLength with integer only input fails

[pocesar]

ngMaxlength seem to be coercing the input value to int? I have

<input ng-model="user.data.numero" ng-maxlength="8" type="text">

which user.data.numero = 232, and it's failing. if I type "n232" it works. Using latest 1.3.0 beta 12

[Narretz]

Hm, in this plunker, $error.maxlength becomes true if I have more than 8 characters in the input:

http://plnkr.co/edit/od2qLXAncyy73FAdqlng?p=preview

So this works. Are your refering to a specific behavior? (In beta.12, the behavior changed insofar that invalid model values will show in the bound input regardless of validity.)

[matsko]

@Narretz you mean that when the validity is failing then the model value will not show up at all.

http://plnkr.co/edit/it2bJvUwaT3VAy2idGQS?p=preview

[Narretz]

@matsko that has always been the case, iirc. The other way round is new (invalid model shows in input). Might actually be a breaking change if you think about it.

[matsko]

Yes it could be overly strict. I think we need another property on ngModel that is there no matter what: #6740 (comment)

[tbosch]

The example above has a mistake: It should be <input type="number">, see here: http://plnkr.co/edit/FPYKrOrTrWKf6PnoaYro?p=preview

Initially, there is no validation error. But when you change the number, the model value gets cleared and the validation error is shown. So this is a legit bug!

[tbosch]

Might be fixed via #7968 though...

[caitp]

That PR should fix it, but it's a good point that it doesn't really make sense for numbers, in general, but it might be good to support for url/email.

[matsko]

The bug is fixed when tested on master: http://plnkr.co/edit/0HKYThxJWZIoHvQIgaol?p=preview

[caitp]

the bug is still happening there with the snapshot script, @matsko

[matsko]

Sorry, my mistake, I though that we were paying attention to the error and not the model value.

[caitp]

well, there's a fix for this but I haven't heard any comments about it =( moving this to the next milestoneeeeee

[Narretz]

As far as I can see the bug in http://plnkr.co/edit/FPYKrOrTrWKf6PnoaYro?p=preview is fixed in the current snapshot.