This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.5k
ng-required conflicts with ng-true-value #5164
Milestone
Comments
This should fix the issue: #7377 |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 27, 2014
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 27, 2014
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Jun 10, 2014
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Jun 10, 2014
matsko
added a commit
to matsko/angular.js
that referenced
this issue
Jun 10, 2014
This is still not working, see this punker with current 1.3.x version (http://plnkr.co/edit/VUAVYLLchaq5bNwgseRp?p=preview)
|
I'll work on this today. |
This still happens. The problem is that $isEmpty is called with the viewValue, and checkboxInputType's $isEmpty returns true when the viewValue is unequal to the trueValue, which will almost always be the case. |
I have a fix for this. Will send PR later. |
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Sep 8, 2014
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Sep 8, 2014
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Sep 9, 2014
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Sep 9, 2014
tbosch
added a commit
to tbosch/angular.js
that referenced
this issue
Sep 10, 2014
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this issue
Nov 21, 2014
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this issue
Nov 21, 2014
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this issue
Nov 23, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I set
ng-required="something"
inside a checkbox,ng-true-value
does not work.This issues happenes with 1.2.x, not with 1.1.x
plunker here
http://plnkr.co/edit/qBLIKaH1XmyQrSN5Xkz0?p=preview
The text was updated successfully, but these errors were encountered: