This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(input): ngMinlength/ngMaxlength should not invalidate non-stringlike values #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -518,7 +518,8 @@ function textInputType(scope, element, attr, ctrl, $sniffer, $browser) { | |||
| if (attr.ngMinlength) { | |||
| var minlength = int(attr.ngMinlength); | |||
| var minLengthValidator = function(value) { | |||
| return validate(ctrl, 'minlength', ctrl.$isEmpty(value) || value.length >= minlength, value); | |||
| return validate(ctrl, 'minlength', ctrl.$isEmpty(value) || | |||
| (isDefined(value.length) ? value.length : Infinity) >= minlength, value); | |||
There was a problem hiding this comment.
Couldn't this just be
!isDefined(value.length) || value.length >= minlength
and similar for maxlength?
There was a problem hiding this comment.
undefined >= 10 for example, would always evaluate to false (and would thus invalidate empty strings, which is not the correct behaviour in html5)
There was a problem hiding this comment.
oh, I see whar you're saying, I can't recall the exact reasons since it's been a while since I wrote this, but there was some mechanical issue involved with that
There was a problem hiding this comment.
I just tried it slightly differently and yeah, works well enough.
…ike values A regression reported in angular#5936 shows that prior to cdc4d48, an input with an ngMinlength or ngMaxlength validator would not invalidate values where value.length was undefined. The behaviour of this validator is still incorrect in the case of objects with a length property which are not arrays or strings, and will most likely remain that way. This cannot change as it is possibly desirable to use ngMinlength/ngMaxlength in conjunction with ngList. Closes angular#5936 Closes angular#6000
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
|
I believe this was basically fixed by 77ce5b8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression reported in #5936 shows that prior to cdc4d48, an input with an ngMinlength or ngMaxlength validator would not invalidate values where value.length was undefined.
This patch addresses this by making use of the Infinity global when a value's length property is undefined.
The behaviour of this validator is still incorrect in the case of objects with a length property which are not arrays or strings, and will most likely remain that way. This cannot change as it is possibly desirable to use ngMinlength/ngMaxlength in conjunction with ngList.
Closes #5936
Closes #6000