-
Notifications
You must be signed in to change notification settings - Fork 27.5k
fix(form): do not prevent submit when action attribute equals to an empty string #3776
Conversation
@agentcooper - Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
Do not prevent submit when action attribute equals to an empty string. Closes #3370
Real name for the CLA: Artem Tyurin |
I'd like to bump this for one of the next releases, but we should add a test for new case in formSpec.js |
I guess it looks okay, it's a bit of a breaking change but I don't think it's likely to hurt anyone -- personally I would just say |
02dc2aa
to
fd2d6c0
Compare
@@ -29,7 +29,7 @@ describe('event directives', function() { | |||
} | |||
}; | |||
|
|||
element = $compile('<form action="" ng-submit="formSubmission($event)">' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not right. the point of the test is to simulate conditions when the form is being submitted. which means that we need the action attribute set to something
I fixed this PR and merged it in. thanks! |
Closes #3370