Testing community changes #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-shameem
commented
Nov 24, 2023
•
ahmed-shameem
commented
- Engine side PR: Merging community commits postgresql_modified_for_babelfish#47
- Engine side PR: Merging community commit - d746021de18baf0f29eff0388204a0664f41eb8b Add construct_array_builtin, deconstruct_array_builtin postgresql_modified_for_babelfish#53
- Engine side PR: Merging community commits from f58f1fb6c0f0990558d0859018b31412b1338447 Add missing GETTEXT_FLAGS entry to 054325c5eeb3140a067ba66735c3d811163ecd6a libpq: Improve idle state handling in pipeline mode postgresql_modified_for_babelfish#54
- Engine side PR: 1ebf00c to 72bc1c1 postgresql_modified_for_babelfish#55
- Engine side PR: BABELFISH-CONFLICT in b0a55e43299c4ea2a9a8c757f9c26352407d0ccc postgresql_modified_for_babelfish#56
- Engine side PR: b0a55e43299c4ea2a9a8c757f9c26352407d0ccc..2373fe78dfc9d4aa2348a86fffdf8eb9d757e9d5 postgresql_modified_for_babelfish#57
- Engine side PR: Merge conflict resolution for 964d01 Automatically generate node support functions postgresql_modified_for_babelfish#58
Signed-off-by: Jason Teng <[email protected]>
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Shameem Ahmed <[email protected]>
This was referenced Nov 28, 2023
Signed-off-by: Jason Teng <[email protected]>
added 2 commits
November 28, 2023 17:14
…ator. Engine commit 8576af873f2dee524237bdb5a5e72be5e7900276 changes some names related to RelFileNode fields, so change them in the extension as well. Task: BABEL-4592 Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
The new node implementation in PG16 is incompatible with how the PIVOT clause was originally written (specifically it tried to use a raw char* List which cannot be copied). This was not an issue earlier due to the fact that the newly added fields were not included in copyfuncs, but that is no longer an option with the new node implementation. Additionally, views now no longer cause a parser issue, but on the other hand they cause a server crash when they are attempted to be called, so for now try to detect the bad cases and raise an error. Signed-off-by: Jason Teng <[email protected]>
Sairakan
reviewed
Nov 28, 2023
| @@ -3839,6 +3839,12 @@ bbf_pivot(PG_FUNCTION_ARGS) | |||
| oldcontext = MemoryContextSwitchTo(tsql_outmost_context); | |||
| PG_TRY(); | |||
| { | |||
| if (!tsql_outmost_estat->pivot_parsetree_list) | |||
There was a problem hiding this comment.
Somehow when a PIVOT is used within a view, this value is NULL, which would cause a segfault in the following line of code without this check. We should probably dig down to find out why this list is being passed as NULL for views.
Signed-off-by: Jason Teng <[email protected]>
This just edits contrib/babelfishpg_tds/test/t/002_tdskerberos.pl to match the changes in 001_auth.pl from community commit 6633cfb216 in the engine. Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
Rather than use superuser or babelfish SA for role administration, use a new role with only CREATEROLE privileges to administrate Babelfish roles. Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Rishabh Tanwar <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Signed-off-by: Jason Teng <[email protected]>
Sairakan
force-pushed
the
pg16-cherry-pick-bff-1
branch
from
1309524 to
43c065f
Compare
This reverts commit 43c065f.
This reverts commit bdf1df0.
Signed-off-by: Rishabh Tanwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.