Support GEOGRAPHY and GEOMETRY datatypes along with TDS Sender Support #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 4, 2023 20:01
Signed-off-by: Anikait Agrawal <[email protected]>
Geography Types Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
…to jira-BABEL-4323 Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Anikait143
force-pushed
the
jira-BABEL-4323
branch
from
27d55f2 to
ec87607
Compare
added 9 commits
September 11, 2023 05:32
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
|
Do we have a way of testing that the build works when postgis fails or is not installed? |
timchang514
reviewed
Sep 13, 2023
test/python/expected/upgrade_validation/expected_dependency.out
Outdated
Show resolved
Hide resolved
timchang514
approved these changes
Sep 19, 2023
Signed-off-by: Anikait Agrawal <[email protected]>
timchang514
reviewed
Sep 19, 2023
kuntalghosh
requested changes
Sep 20, 2023
Signed-off-by: Anikait Agrawal <[email protected]>
Anikait143
requested review from
timchang514,
rishabhtanwar29 and
kuntalghosh
rishabhtanwar29
approved these changes
Sep 21, 2023
kuntalghosh
requested changes
Sep 22, 2023
contrib/babelfishpg_common/sql/upgrades/other_types--3.2.0--3.3.0.sql
Outdated
Show resolved
Hide resolved
contrib/babelfishpg_common/sql/upgrades/babelfishpg_upgrades.in
Outdated
Show resolved
Hide resolved
Signed-off-by: Anikait Agrawal <[email protected]>
kuntalghosh
approved these changes
Sep 26, 2023
2jungkook
reviewed
Sep 26, 2023
timchang514
approved these changes
Sep 27, 2023
2jungkook
approved these changes
Sep 27, 2023
jsudrik
merged commit 00c87ad
into
babelfish-for-postgresql:BABEL_3_X_DEV
26 checks passed
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 21, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad. THIS IS A TEMPORARY REVERT TO ALLOW THE GITHUB ACTIONS TO RUN TESTS. THIS NEEDS TO BE UN-REVERTED AFTER BABEL_main IS BROUGHT UP TO DATE
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 21, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 21, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 23, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 24, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 27, 2023
…r Support (babelfish-for-postgresql#1819)" This reverts commit 00c87ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AS Babel User
I WANT support to be added for GEOGRAPHY and GEOMETRY data types
SO I can use this special data type to store and manipulate geospatial data
This PR contains Support for GEOGRAPHY and GEOGRAPHY datatype for Point Type and also TDS sender Support for
these Spatial DataTypes so that we can send result of queries with GEOGRAPHY and GEOMETRY columns to TDS clients.
Added SQL files which contains the following definitions and functionalities:
[Geography variable]
[Geography column]
[Geometry variable]
[Geometry column]
Spatial type modifier [Point]
Spatial method [.Lat]
Spatial method [.Long]
Spatial support method [STGeomFromText]
Spatial support method [STPointFromText]
Spatial support method [.STDistance]
Spatial support method .STAsText
Spatial support method .STAsBinary
as well as modifications to the antlr parser in order to support the scope parameter (::)
Added new tests TestSpatialPoint-vu-* to test these implemented functionalities.
Added build scripts for PostGIS extension in the Github Actions.
Added Spatial Type Enable Switch so that user can freely use these types after building PostGIS Extension
Created a new version dump - 3.3.0 (babelfishpg_common--3.2.0--3.3.0.sql) to support the sql files for spatialtypes
Created automated creation for upgrade files
Task: BABEL- 4323
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]
Test Scenarios Covered
Use case based - TestSpatialPoint-vu-*
Boundary conditions -
Arbitrary inputs -
Negative test cases - TestSpatialPoint-vu-*
Minor version upgrade tests - added PostGIS installation scripts to Github Actions and upgrade file babelfishpg_common--3.2.0--3.3.0.sql
Major version upgrade tests - added PostGIS installation scripts to Github Actions and upgrade file babelfishpg_common--3.2.0--3.3.0.sql
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.