Implement Supported Geospatial CASTs #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2023 11:50
… types Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
timchang514
reviewed
Oct 23, 2023
added 3 commits
October 24, 2023 06:29
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
…-4501 Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
test/python/expected/upgrade_validation/expected_dependency.out
Outdated
Show resolved
Hide resolved
added 3 commits
November 6, 2023 15:58
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
rishabhtanwar29
approved these changes
Nov 7, 2023
Anikait143
changed the title
Anikait143
changed the title
timchang514
approved these changes
Nov 8, 2023
|
Approved, but let's also keep aware of anything that might need addressing once the changes hit GitFarm, since the build process will be different - files, dependencies will be different. |
shardgupta
approved these changes
Nov 8, 2023
shardgupta
merged commit de7d858
into
babelfish-for-postgresql:BABEL_3_X_DEV
28 checks passed
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 21, 2023
Sairakan
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 21, 2023
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 23, 2023
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 24, 2023
ahmed-shameem
pushed a commit
to amazon-aurora/babelfish_extensions
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit contains Tests and Fixes for Supported and Unsupported CASTs for Geospatial Data Types.
Added Casts which need to be supported for Geospatial Data Types.
Disabled Casts which were being supported but weren't meant to be supported.
Added proper CASTing Tests for JDBC driver in TestSpatialPoint-vu-* test files (for both IMPLICIT and EXPLICIT CASTs)
Updated PostGIS and Proj versions according to gitfarm to remove any differences b/w github and gitfarm
Task: BABEL- 4501
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]
Test Scenarios Covered
Use case based - TestSpatialPoint-vu-*
Boundary conditions -
Arbitrary inputs -
Negative test cases - TestSpatialPoint-vu-* (unsupported casts)
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.