-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented TDS Receiver Support for Spatial Datatypes and Tested both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers #1921
Conversation
sender and Receiver functions with JDBC, ODBC and DOTNET Drivers Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
…to jira-BABEL-4369
Signed-off-by: Anikait Agrawal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, tests for supported/unsupported casts are missing but it can be done in a followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, but error messages should be clarified
Signed-off-by: Anikait Agrawal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove AS BABEL user
part from the description as we don't need to mention it again and mention this commit
instead of this PR
as eventually the description is going to commit message.
3a0259b
into
babelfish-for-postgresql:BABEL_3_X_DEV
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
…sted both Sender and Receiver functions with JDBC, ODBC and DOTNET Drivers (babelfish-for-postgresql#1921)" This reverts commit 3a0259b.
Description
This commit contains Receiver Support for GEOGRAPHY and GEOGRAPHY datatype for Point Type and also tested the Sender and Receiver functions with JDBC, ODBC and DOTNET drivers.
Added CAST (Varbinary to Geometry/Geography and vice-versa) required by JDBC driver to receiver Geometry/Geography as Varbinary.
Introduced appropriate error messages when an unsupported functionality(such as LINESTRING) is queried.
Added Receiver function required by DOTNET driver to receiver Geometry/Geography as CLRUDT types.
Added new tests in TestSpatialPoint-vu-* to test receiver function for JDBC driver.
Added logic to parse the geometry/geography inputs in JDBCPreparedStatement.java file.
Added new tests TestPoint.txt to test Sender and Receiver functions for DOTNET driver.
Added logic to parse the geometry/geography inputs in PrepareExecBinding.cs file.
Added new tests geometry.cpp and geography.cpp to test Sender and Receiver functions for ODBC driver.
Added some sender function tests in test_data_types.cpp file for ODBC driver.
Tested the changes with valgrind and didn't see any memory issues.
Task: BABEL- 4369
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]
Test Scenarios Covered
Use case based - TestSpatialPoint-vu-*, TestPoint.txt, geometry.cpp, geography.cpp
Boundary conditions -
Arbitrary inputs -
Negative test cases - TestSpatialPoint-vu-*
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Memory tests - Tested the changes with valgrind
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.