-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to govuk-elements-sass v3.1.1 #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #412. Uses date example from GOV.UK elements.
Move the form-hint inside the label, so it is read by screen readers when the input is focussed.
These examples move the h1 inside the legend and add extra text - select one, or select all. Split the radio buttons and checkboxes examples onto separate pages.
This removes the duplication of the h1 and legend text.
Fixes #376.
The main heading for the page is “Application complete”.
gemmaleigh
force-pushed
the
govuk-elements-sass-3.1.1
branch
from
September 7, 2017 09:48
63d7f87
to
2fcb9c8
Compare
hannalaakso
approved these changes
Sep 7, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with @gemmaleigh and @alex-ju. Looks great :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.1
<details>
element doesn't follow the specified structure (PR #521).3.1.0
.body-text
for use inside legends, for text to accompany radio buttons or checkboxes - either 'select one', or 'select all that apply'. Ensure legends or elements within legends have margins in webkit browsers (PR #484)..form-section
and.form-group
(PR #487).Changes made to the prototype kit