Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date example markup is out of step with Elements #412

Closed
edwardhorsford opened this issue Jul 21, 2017 · 0 comments · Fixed by #415
Closed

Date example markup is out of step with Elements #412

edwardhorsford opened this issue Jul 21, 2017 · 0 comments · Fixed by #415

Comments

@edwardhorsford
Copy link
Contributor

The markup in the kit for date inputs is out of step with Elements - it uses p which adds a lot of unnecessary margin and isn't programmatically associated with the inputs.

Elements examples here.
gemmaleigh added a commit that referenced this issue Jul 28, 2017
@gemmaleigh
Update elements example - date of birth
dc09f9a 
Fixes #412. Uses date example from GOV.UK elements.
gemmaleigh added a commit that referenced this issue Jul 28, 2017
@gemmaleigh
Update elements example - date of birth
2bbef36 
Fixes #412. Uses date example from GOV.UK elements.
@gemmaleigh gemmaleigh mentioned this issue Jul 28, 2017
Merged
gemmaleigh added a commit that referenced this issue Sep 7, 2017
@gemmaleigh
Update elements example - date of birth
f84f3de 
Fixes #412. Uses date example from GOV.UK elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to govuk-elements-sass v3.1.1 alphagov/govuk-prototype-kit
1 participant
@edwardhorsford