Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to govuk-elements-sass v3.1.1 #415

Merged
merged 13 commits into from
Sep 7, 2017
Merged

Conversation

gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented Jul 28, 2017

3.1.1

  • Only make column headers bold, not row headers (PR #483)
  • De-duplicate legends/headings when there is one question per page by placing the heading for the question inside the legend of the fieldset (PR #507).
  • Set cursor: default for for both the disabled input and the label - for radio buttons and checkboxes (PR #519).
  • Fix stray line on checkboxes on IE11 caused by miscalculation of the border width of rotated element (PR #520).
  • Fix hard error in details.polyfill.js raised when the <details> element doesn't follow the specified structure (PR #521).

3.1.0

  • Split the list of partials imported by GOV.UK elements into two further files - elements and frontend-toolkit. This supports npm-sass, where the frontend toolkit dependencies are imported separately (PR #489).
  • Add a new class .body-text for use inside legends, for text to accompany radio buttons or checkboxes - either 'select one', or 'select all that apply'. Ensure legends or elements within legends have margins in webkit browsers (PR #484).
  • Move the breadcrumb so it sits outside the main element (PR #478)
  • Constrain error summary boxes to 2/3 of the page width (PR #477)
  • Remove the right padding from the last column of items in a table, also remove color set for table headers and cells, to allow users to change colour settings (PR #482
  • Align table captions to the left (PR #476).
  • Add guidance for use of table captions (PR #488).
  • Fix unnecessary float and width 100% for .form-section and .form-group (PR #487).
  • Fix incorrect margin above the last panel in a group (PR #498).
  • Add guidance for the mininum text size to be used with the highlight box on confimation boxes (PR #481).

Changes made to the prototype kit

greenkeeper bot and others added 13 commits September 7, 2017 10:48
Fixes #412. Uses date example from GOV.UK elements.
Move the form-hint inside the label, so it is read by screen readers
when the input is focussed.
These examples move the h1 inside the legend and add extra text -
select one, or select all.

Split the radio buttons and checkboxes examples onto separate pages.
This removes the duplication of the h1 and legend text.
The main heading for the page is “Application complete”.
@gemmaleigh gemmaleigh force-pushed the govuk-elements-sass-3.1.1 branch from 63d7f87 to 2fcb9c8 Compare September 7, 2017 09:48
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @gemmaleigh and @alex-ju. Looks great :)

@hannalaakso hannalaakso merged commit 6047266 into master Sep 7, 2017
@hannalaakso hannalaakso deleted the govuk-elements-sass-3.1.1 branch September 7, 2017 10:20
@joelanman joelanman mentioned this pull request Sep 27, 2017
@alex-ju alex-ju removed their assignment Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants