Fix #502: hard error in details.polyfill.js #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polyfill script expected <details> to contain a <summary> and a <div> representing the content. If the structure doesn't exists the script will not continue, as the <details> component can be potentially used in other scenarios across the page.
|
@alex-ju can you squash those commits together please? Give me a shout if you want a hand. |
The polyfill script expected <details> to contain a <summary> and a <div> representing the content. If the structure doesn't exists the script will not continue, as the <details> component can be potentially used in other scenarios across the page.
|
Squashed & merged. |
alex-ju
changed the title
alex-ju
changed the title
gemmaleigh
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
Jul 28, 2017
gemmaleigh
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does the pull request solve?
The details.polyfill.js script expected
<details>to contain a<summary>and a<div>representing the content. If this structure didn't exists the script crashes with a hard error as shown in #502.As the
<details>component can be potentially used in other scenarios across the page, if the structure is not followed, the polyfill script will not be executed.How has this been tested?
Tested locally: Latest Safari, Firefox and Chrome on Mac
Tester with BrowserStack: IE11 and Edge15 on Windows.
What type of change is it?
Has the documentation been updated?