Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard error in details.polyfill.js #502

Closed
abbott567 opened this issue Jun 15, 2017 · 1 comment
Closed

Hard error in details.polyfill.js #502

abbott567 opened this issue Jun 15, 2017 · 1 comment

Comments

@abbott567
Copy link

If you try to use a <details> tag without markup suggested on govuk-elements, details.polyfill.js throws the following error in the console:

details.polyfill.js:94 Uncaught TypeError: Cannot read property 'id' of null
    at addDetailsPolyfill (details.polyfill.js:94)

As the HTML markup is technically not invalid, I would say that it is incorrect to throw a hard error just because you're using markup that differs to the recommended example. Perhaps a softer warning that you're not using the recommended markup is more appropriate.

@gemmaleigh
Copy link
Contributor

Fixed by #521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants