-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update govuk-elements-sass to the latest version 🚀 #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaleigh
approved these changes
Jun 23, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.1.0
- Split the list of partials imported by GOV.UK elements into two further files - elements and frontend-toolkit. This supports npm-sass, where the frontend toolkit dependencies are imported separately (PR #489).
- Add a new class
.body-text
for use inside legends, for text to accompany radio buttons or checkboxes - either 'select one', or 'select all that apply'. Ensure legends or elements within legends have margins in webkit browsers (PR #484). - Move the breadcrumb so it sits outside the main element (PR #478)
- Constrain error summary boxes to 2/3 of the page width (PR #477)
- Remove the right padding from the last column of items in a table, also remove color set for table headers and cells, to allow users to change colour settings (PR #482
- Align table captions to the left (PR #476).
- Add guidance for use of table captions (PR #488).
- Fix unnecessary float and width 100% for
.form-section
and.form-group
(PR #487). - Fix incorrect margin above the last panel in a group (PR #498).
- Add guidance for the mininum text size to be used with the highlight box on confimation boxes (PR #481).
- Update govuk_template_jinja to 0.22.0 (PR #493).
Version 3.1.1 just got published. |
gemmaleigh
force-pushed
the
greenkeeper/govuk-elements-sass-3.1.0
branch
from
July 28, 2017 15:49
b64feca
to
db20dae
Compare
Fixes #412. Uses date example from GOV.UK elements.
Move the form-hint inside the label, so it is read by screen readers when the input is focussed.
These examples move the h1 inside the legend and add extra text - select one, or select all. Split the radio buttons and checkboxes examples onto separate pages.
This removes the duplication of the h1 and legend text.
Fixes #376.
gemmaleigh
force-pushed
the
greenkeeper/govuk-elements-sass-3.1.0
branch
from
July 28, 2017 15:53
db20dae
to
e24bc46
Compare
Closing in favour of #415. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.1.0 of govuk-elements-sass just got published.
The version 3.1.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of govuk-elements-sass.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
v3.1.03.1.0
This supports npm-sass, where the frontend toolkit dependencies are imported separately (PR #489).
.body-text
for use inside legends, for text to accompany radio buttons or checkboxes - either 'select one', or 'select all that apply'.Ensure legends or elements within legends have margins in webkit browsers (PR #484).
Remove color set for table headers and cells, to allow users to change colour settings (PR #482
.form-section
and.form-group
(PR #487).Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴