Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove float and width 100% from form group #487

Merged
merged 3 commits into from
Jun 14, 2017

Conversation

gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented Jun 6, 2017

What problem does the pull request solve?

Removes float and width 100%, for .form-group, .form-section, .form-block.

Fixes #257.

What type of change is it?

Bug fix (non-breaking change which fixes an issue)

Has the documentation been updated?

I have read the CONTRIBUTING document.

This isn’t required as is preventing the form-group container from
clearing its children.
@gemmaleigh gemmaleigh temporarily deployed to govuk-elements-review-pr-487 June 6, 2017 08:16 Inactive
@gemmaleigh gemmaleigh changed the title [wip] Remove float and width 100% from form group Remove float and width 100% from form group Jun 13, 2017
As it sits between radio or checkbox options, use float: left; clear:
left as .multiple-choice elements are floated.
@gemmaleigh gemmaleigh force-pushed the remove-float-form-group branch from 2248c42 to 7719da2 Compare June 13, 2017 16:27
Copy link

@dankmitchell dankmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@gemmaleigh gemmaleigh merged commit 7d07d9d into master Jun 14, 2017
@gemmaleigh gemmaleigh deleted the remove-float-form-group branch June 14, 2017 14:53
matteason added a commit to uktrade/lite-play-common-archive that referenced this pull request Jul 6, 2017
Merging alphagov/govuk_elements#487 to fix form group float causing heading padding to disappear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.form-group has float and width 100%
2 participants