Improved max_concurrency aware ShardManager #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonovanDMC
suggested changes
May 6, 2022
DonovanDMC
previously approved these changes
May 6, 2022
DonovanDMC
added a commit
to DonovanArchive/ErisPRUpdateBot
that referenced
this pull request
May 7, 2022
- rename "main" to "upstream" - add "everything-v10" branch Additions: - abalabahaha/eris#1283 - abalabahaha/eris#1285 - abalabahaha/eris#1332 - abalabahaha/eris#1344 - abalabahaha/eris#1351 - abalabahaha/eris#1355 - abalabahaha/eris#1358 - abalabahaha/eris#1359 - abalabahaha/eris#1363 - abalabahaha/eris#1366 - abalabahaha/eris#1367 - abalabahaha/eris#1368 - abalabahaha/eris#1369 - abalabahaha/eris#1370 Removals: - abalabahaha/eris#1305 - abalabahaha/eris#1314 - abalabahaha/eris#1325
DonovanDMC
approved these changes
Jun 2, 2022
DonovanDMC
added a commit
to DonovanArchive/ErisPRUpdateBot
that referenced
this pull request
Jun 8, 2022
Additions: - abalabahaha/eris#1275 - abalabahaha/eris#1309 (technically) - abalabahaha/eris#1379 - abalabahaha/eris#1384 Removals: - abalabahaha/eris#1328 - abalabahaha/eris#1332 -abalabahaha/eris# 1335 - abalabahaha/eris#1344 - abalabahaha/eris#1363 - abalabahaha/eris#1367 - abalabahaha/eris#1370 - abalabahaha/eris#1376 - remove `interactions` branch - remove unused remotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes ShardManager
max_concurrencyaware. Shards in differentrate_limit_key(https://discord.com/developers/docs/topics/gateway#sharding-max-concurrency) buckets start in parallel resulting in significantly faster startup times across the board for large scale discord bots. Here is a table (these were tested from intent enabled tokens):