Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guild Scheduled Events #1275

Merged
merged 84 commits into from
Nov 18, 2022
Merged

Guild Scheduled Events #1275

merged 84 commits into from
Nov 18, 2022

Conversation

Loliticos
Copy link
Contributor

@Loliticos Loliticos commented Sep 6, 2021

Discord is implementing Scheduled Guild Events (discord/discord-api-docs#3586). This pull request is a start in order to implement this new feature.

New Events

  • GUILD_SCHEDULED_EVENT_CREATE (guildScheduledEventCreate)
  • GUILD_SCHEDULED_EVENT_UPDATE (guildScheduledEventUpdate)
  • GUILD_SCHEDULED_EVENT_DELETE (guildScheduledEventDelete)
  • GUILD_SCHEDULED_EVENT_USER_ADD (guildScheduledEventUserAdd)
  • GUILD_SCHEDULED_EVENT_USER_REMOVE(guildScheduledEventUserRemove)

Additions

  • GuildEvent
  • Client#guildEventMap
  • Client#createGuildEvent()
  • Client#deleteGuildEvent()
  • Client#editGuildEvent()
  • Client#getRESTGuildEvent()
  • Guild#events

TODO

  • Document new Client, Guild and GuildEvent methods
  • GUILD_SCHEDULED_EVENT_USER_ADD (Gateway Event)
  • GUILD_SCHEDULED_EVENT_USER_REMOVE (Gateway Event)

@Loliticos Loliticos marked this pull request as draft September 6, 2021 04:22
@JustCat80
Copy link
Contributor

ooo this sounds cool

Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've been pretty clear that everything should be alphabetically sorted unless otherwise stated...

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Constants.js Outdated Show resolved Hide resolved
lib/gateway/Shard.js Outdated Show resolved Hide resolved
lib/structures/GuildEvent.js Outdated Show resolved Hide resolved
lib/structures/GuildEvent.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Apr 13, 2022

Testing required for this please

@bsian03 bsian03 self-requested a review April 13, 2022 22:18
lib/structures/GuildScheduledEvent.js Outdated Show resolved Hide resolved
lib/structures/GuildScheduledEvent.js Show resolved Hide resolved
lib/structures/GuildScheduledEvent.js Outdated Show resolved Hide resolved
lib/structures/GuildScheduledEvent.js Outdated Show resolved Hide resolved
lib/structures/GuildScheduledEvent.js Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
DonovanDMC
DonovanDMC previously approved these changes Jun 7, 2022
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Jun 8, 2022
@abalabahaha abalabahaha modified the milestones: 0.18.x, 0.17.x Jun 29, 2022
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested

@DonovanDMC DonovanDMC self-assigned this Aug 20, 2022
@DonovanDMC DonovanDMC removed their assignment Aug 29, 2022
Jam-Manbo pushed a commit to Manbo-js/manbo that referenced this pull request Sep 28, 2022
@bsian03 bsian03 merged commit 3e62ca7 into abalabahaha:dev Nov 18, 2022
curtisf pushed a commit to curtisf/eris that referenced this pull request Jun 11, 2023
Co-authored-by: Bsian <[email protected]>
Co-authored-by: HeadTriXz <[email protected]>
Co-authored-by: Donovan Daniels <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants