Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall Consistency Fixes & Minor Feature Additions #1379

Closed
wants to merge 57 commits into from

Conversation

DonovanDMC
Copy link
Contributor

@DonovanDMC DonovanDMC commented May 30, 2022

This is nowhere near done, I'm planning on combing through most classes & interfaces and fixing up things as I go - I'm just creating the pr now to open discussions

@DonovanDMC DonovanDMC marked this pull request as draft May 30, 2022 18:09
@abalabahaha abalabahaha added this to the 0.17.x milestone Jun 29, 2022
- `nsfw` is not present on stage channels or threads
- `userLimit` is not present on stage channels
- `videoQualityMode` is not present on stage channels
@DonovanDMC
Copy link
Contributor Author

I'm looking further into thread channels, and we're reporting them as having a few properties they don't have. I don't know if we're just okay with that, or if we want to do something about it. The only properties shared between all channels is id, name, parent_id & type. We're reporting position & permission_overwrites along with those, which is incorrect.

@HeadTriXz
Copy link
Contributor

If it's incorrect, it should be fixed.

@DonovanDMC
Copy link
Contributor Author

Store channels don't really exist anymore, so I'm mostly just dancing around store channels right now
I'd love for #1405 to go in before this (or at least with this) so store channels can be fully done away with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants