Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slash): Snake case defaultPermissions to payload #1325

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix(slash): Snake case defaultPermissions to payload #1325

merged 1 commit into from
Feb 11, 2022

Conversation

bsian03
Copy link
Collaborator

@bsian03 bsian03 commented Jan 17, 2022

No description provided.

@bsian03 bsian03 added the bug label Jan 17, 2022
@coolcalcacol
Copy link
Contributor

I thought this was in another PR @bsian03?

@DonovanDMC
Copy link
Contributor

I left it as snake case as most things around interactions is already snake case

@bsian03
Copy link
Collaborator Author

bsian03 commented Jan 17, 2022

Did the PR with the intention that it would be merged first - Donovan's PR would also technically cause a breaking change from the docs perspective

@DonovanDMC
Copy link
Contributor

I'll just take it out of my pr, since this will almost certainly make it in first, and that is true

DonovanDMC added a commit to DonovanDMC/eris that referenced this pull request Jan 17, 2022
@DonovanDMC
default_permission -> defaultPermission (abalabahaha#1325)
791be08
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Feb 10, 2022
@DonovanDMC
Additions & Removals
1c67498 
Add:
- abalabahaha/eris#1193
- abalabahaha/eris#1305
- abalabahaha/eris#1314
- abalabahaha/eris#1318
- abalabahaha/eris#1323
- abalabahaha/eris#1325
- abalabahaha/eris#1328
- abalabahaha/eris#1335

Remove:
- abalabahaha/eris#1311
@bsian03 bsian03 merged commit 90fad3a into abalabahaha:dev Feb 11, 2022
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request May 7, 2022
@DonovanDMC
Read Description (Additions & Removals)
38c2bab 
- rename "main" to "upstream"
- add "everything-v10" branch
Additions:
- abalabahaha/eris#1283
- abalabahaha/eris#1285
- abalabahaha/eris#1332
- abalabahaha/eris#1344
- abalabahaha/eris#1351
- abalabahaha/eris#1355
- abalabahaha/eris#1358
- abalabahaha/eris#1359
- abalabahaha/eris#1363
- abalabahaha/eris#1366
- abalabahaha/eris#1367
- abalabahaha/eris#1368
- abalabahaha/eris#1369
- abalabahaha/eris#1370

Removals:
- abalabahaha/eris#1305
- abalabahaha/eris#1314
- abalabahaha/eris#1325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@See887777 See887777 See887777 approved these changes

@curtisf curtisf curtisf approved these changes

@DonovanDMC DonovanDMC DonovanDMC approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bsian03 @coolcalcacol @DonovanDMC @curtisf @See887777