Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework file attachments #1285

Merged
merged 15 commits into from
Jan 5, 2024
Merged

Rework file attachments #1285

merged 15 commits into from
Jan 5, 2024

Conversation

bsian03
Copy link
Collaborator

@bsian03 bsian03 commented Oct 16, 2021

This should futureproof endpoints requiring a multipart/form-data with a JSON body

@bsian03 bsian03 changed the title Rework multipart/form-data construction Rework file attachments Oct 30, 2021
@bsian03 bsian03 mentioned this pull request Jan 27, 2022
Closed
@bsian03 bsian03 mentioned this pull request Apr 12, 2022
Closed
@bsian03 bsian03 linked an issue Apr 12, 2022 that may be closed by this pull request
editMessage and editWebhookMessage send attachments twice in the same request #1356
Closed
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request May 7, 2022
@DonovanDMC
Read Description (Additions & Removals)
38c2bab 
- rename "main" to "upstream"
- add "everything-v10" branch
Additions:
- abalabahaha/eris#1283
- abalabahaha/eris#1285
- abalabahaha/eris#1332
- abalabahaha/eris#1344
- abalabahaha/eris#1351
- abalabahaha/eris#1355
- abalabahaha/eris#1358
- abalabahaha/eris#1359
- abalabahaha/eris#1363
- abalabahaha/eris#1366
- abalabahaha/eris#1367
- abalabahaha/eris#1368
- abalabahaha/eris#1369
- abalabahaha/eris#1370

Removals:
- abalabahaha/eris#1305
- abalabahaha/eris#1314
- abalabahaha/eris#1325
DonovanDMC
DonovanDMC reviewed May 8, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@bsian03 @DonovanDMC
Update index.d.ts
06721e5 
Co-authored-by: Donovan Daniels <[email protected]>
DonovanDMC
DonovanDMC previously requested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@DonovanDMC DonovanDMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

DonovanDMC
DonovanDMC suggested changes Jun 9, 2022
View reviewed changes
lib/Client.js Show resolved Hide resolved
DonovanDMC
DonovanDMC suggested changes Jun 9, 2022
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
DonovanDMC
DonovanDMC reviewed Jun 9, 2022
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
DonovanDMC
DonovanDMC reviewed Jun 9, 2022
View reviewed changes
lib/Client.js Outdated Show resolved Hide resolved
@TheEssem
Copy link

TheEssem commented Jun 28, 2022 •
edited
Loading

Seems to break sending an attachment alongside text content when using CommandInteraction#createMessage, causing Discord to return a 50035 error with the content Only dictionaries may be used in a ModelType.

@abalabahaha abalabahaha added this to the 0.17.x milestone Jun 29, 2022
@DonovanDMC
Copy link
Contributor

Seeing as this has a lot of ongoing issues it would be nice for them to either be fixed or get at least some kind of time frame

DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Jul 18, 2022
@DonovanDMC
rebase
ad7f50d 
Removals:
- abalabahaha/eris#1283
- abalabahaha/eris#1285
- abalabahaha/eris#1369

Additions:
- abalabahaha/eris#494
- abalabahaha/eris#1193
- abalabahaha/eris#1338
- abalabahaha/eris#1386
@HeadTriXz
Copy link
Contributor

Any update on this PR?

HeadTriXz
HeadTriXz suggested changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@HeadTriXz HeadTriXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert broken changes (thanks GitHub)

lib/Client.js Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/Client.js Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
@eritbh eritbh mentioned this pull request Sep 4, 2022
Closed
@bsian03
Copy link
Collaborator Author

bsian03 commented Jan 4, 2024

Seems to break sending an attachment alongside text content when using CommandInteraction#createMessage, causing Discord to return a 50035 error with the content Only dictionaries may be used in a ModelType.

This should be fixed from my testing, I'm getting @beanjo55 to double check as well

@bsian03 bsian03 merged commit 65ab78b into abalabahaha:dev Jan 5, 2024
@bsian03 bsian03 mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonovanDMC DonovanDMC DonovanDMC requested changes

@HeadTriXz HeadTriXz HeadTriXz requested changes

Assignees
No one assigned
Labels
Discord enhancement hacktoberfest-accepted
Projects
None yet
Milestone
0.17.3
Development

Successfully merging this pull request may close these issues.

editMessage and editWebhookMessage send attachments twice in the same request
5 participants
@bsian03 @TheEssem @DonovanDMC @HeadTriXz @abalabahaha