Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interactions): Localization #1335

Closed
wants to merge 20 commits into from
Closed

feat(interactions): Localization #1335

wants to merge 20 commits into from

Conversation

DonovanDMC
Copy link
Contributor

@DonovanDMC DonovanDMC commented Feb 9, 2022 •
edited
Loading

Locale stuff for interactions, extracted from #1309

Draft until #1309 is merged

DonovanDMC added a commit to DonovanDMC/eris that referenced this pull request Feb 9, 2022
@DonovanDMC
move locale into abalabahaha#1335
645481b
@bsian03
Copy link
Collaborator

bsian03 commented Feb 10, 2022

Am deferring until #1303 and #1309 are merged to make life easier

@DonovanDMC DonovanDMC marked this pull request as draft February 10, 2022 09:44
DonovanDMC added a commit to DonovanArchive/ErisPRUpdateBot that referenced this pull request Feb 10, 2022
@DonovanDMC
Additions & Removals
1c67498 
Add:
- abalabahaha/eris#1193
- abalabahaha/eris#1305
- abalabahaha/eris#1314
- abalabahaha/eris#1318
- abalabahaha/eris#1323
- abalabahaha/eris#1325
- abalabahaha/eris#1328
- abalabahaha/eris#1335

Remove:
- abalabahaha/eris#1311
@DonovanDMC DonovanDMC changed the title Interaction Locales feat(interactions): Localization Mar 25, 2022
@DonovanDMC DonovanDMC closed this Mar 25, 2022
@DonovanDMC DonovanDMC deleted the interactions-locale branch March 25, 2022 00:53
@DonovanDMC DonovanDMC restored the interactions-locale branch March 25, 2022 00:53
@DonovanDMC DonovanDMC reopened this Mar 25, 2022
@DonovanDMC
Copy link
Contributor Author

I hate github

DonovanDMC added a commit to DonovanDMC/eris that referenced this pull request Mar 25, 2022
@DonovanDMC
combine abalabahaha#1309 & abalabahaha#1335
f956ebb
@DonovanDMC
Copy link
Contributor Author

Folding this back into #1309 to make things easier

@DonovanDMC DonovanDMC closed this Jun 1, 2022
@DonovanDMC DonovanDMC deleted the interactions-locale branch June 1, 2022 14:58
DonovanDMC added a commit to DonovanDMC/eris that referenced this pull request Jun 1, 2022
@DonovanDMC
Fold abalabahaha#1335
f1dcc00
@bsian03 bsian03 mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Discord enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonovanDMC @bsian03