Enable native editor onboarding features globally #35201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Feature] Inserter
2 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
We decided to enable the new block badge for all users.
Now that block impressions are enabled for all users, we must update the test expectation to include the `isNew` property set by `useBlockTypeImpression`. An alternative would be to update this test to not explicitly check the component prop, but the rendered result which the user can see.
dcalhoun
force-pushed
the
feature/enable-editor-onboarding-globally
branch
from
d348ca0 to
dc3e3d4
Compare
The bridging methods are no longer necessary now that we display editor onboarding features for all users.
This was referenced Oct 6, 2021
This feature was delivered in a previous release via a beta fix.
dcalhoun
commented
Oct 6, 2021
...droid/react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/GutenbergProps.kt
Outdated
Show resolved
Hide resolved
mchowning
approved these changes
Oct 8, 2021
...droid/react-native-bridge/src/main/java/org/wordpress/mobile/WPAndroidGlue/GutenbergProps.kt
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/inserter/test/block-types-tab.native.js
Outdated
Show resolved
Hide resolved
…nable-editor-onboarding-globally
Place fixture setup in fixture file rather than within test file.
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
We decided to enable the native editor onboarding features for all users, e.g. the new block badge.
How has this been tested?
New Block Badge
Help Section
Screenshots
TBD
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).