Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable native editor onboarding features globally #15425

Merged
merged 10 commits into from
Oct 25, 2021
Merged

Enable native editor onboarding features globally #15425

merged 10 commits into from
Oct 25, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 6, 2021 •
edited
Loading

Related PRs

Description

We decided to enable the native editor onboarding features for all users, e.g. the new block badge.

To test:

In addition to the following, see WordPress/gutenberg#35201.

  1. Install the PR build.
  2. Launch the block editor.
  3. Close the block editor.
  4. ℹ️ Expected: The wpandroid_editor_session_start and wpandroid_editor_session_end events fire in Tracks with expected properties:
    • Excludes can_view_editor_onboarding

Regression Notes

  1. Potential unintended areas of impact
    The block editor or related analytic events may break.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I manually verified the block editor and editor session events functioned as expected.
  3. What automated tests I added (or what prevented me from doing so)
    This PR focused on code removal, not feature additions or bug fixes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun
Update gutenbergMobileVersion ref
021a6e3
@dcalhoun
Display editor help button for all users
fa15822 
We decided to enable the help section for all users.
@dcalhoun
Remove editor onboarding cohort logic
cc2724d 
We decided to release the editor onboarding features to all users.
@dcalhoun
Update gutenbergMobileVersion ref
b42dd91
@dcalhoun dcalhoun added Analytics Support Gutenberg Editing and display of Gutenberg blocks. labels Oct 6, 2021
@dcalhoun dcalhoun added this to the 18.5 milestone Oct 6, 2021
@dcalhoun dcalhoun self-assigned this Oct 6, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 6, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

This was referenced Oct 6, 2021
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 6, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

@dcalhoun dcalhoun marked this pull request as ready for review October 6, 2021 18:03
mchowning
mchowning approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! 👍

@dcalhoun dcalhoun modified the milestones: 18.5, 18.6 Oct 14, 2021
@dcalhoun dcalhoun merged commit d3e6f07 into develop Oct 25, 2021
@dcalhoun dcalhoun deleted the feature/enable-editor-onboarding-globally branch October 25, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchowning mchowning mchowning approved these changes

Assignees

@dcalhoun dcalhoun

Labels
Analytics Gutenberg Editing and display of Gutenberg blocks. Support
Projects
None yet
Milestone
18.6
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @mchowning