Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable native editor onboarding features globally #17268

Merged
merged 8 commits into from
Oct 25, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 6, 2021

Related PRs

Description

We decided to enable the native editor onboarding features for all users, e.g. the new block badge.

To test:

In addition to the following, see WordPress/gutenberg#35201.

  1. Install the PR build.
  2. Launch the block editor.
  3. Close the block editor.
  4. ℹ️ Expected: The wpios_editor_session_start and wpios_editor_session_end events fire in Tracks with expected properties:
    • Includes blogid
    • Excludes can_view_editor_onboarding

Regression Notes

  1. Potential unintended areas of impact
    The block editor or related analytic events may break.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    I manually verified the block editor and editor session events functioned as expected.
  3. What automated tests I added (or what prevented me from doing so)
    This PR focused on code removal, not feature additions or bug fixes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

We decided to release the editor onboarding features to all users.
@dcalhoun dcalhoun added Support Analytics Gutenberg Editing and display of Gutenberg blocks. labels Oct 6, 2021
@dcalhoun dcalhoun added this to the 18.5 milestone Oct 6, 2021
@dcalhoun dcalhoun self-assigned this Oct 6, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 6, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 6, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun dcalhoun marked this pull request as ready for review October 6, 2021 18:03
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! 👍

@dcalhoun dcalhoun modified the milestones: 18.5, 18.6 Oct 14, 2021
We no longer have code relying upon this flag.
…nto feature/enable-editor-onboarding-globally
@dcalhoun dcalhoun enabled auto-merge October 25, 2021 21:37
@dcalhoun dcalhoun merged commit b13e26a into develop Oct 25, 2021
@dcalhoun dcalhoun deleted the feature/enable-editor-onboarding-globally branch October 25, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Gutenberg Editing and display of Gutenberg blocks. Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants