[RNMobile] Look for newly available blocks too during E2E tests #35948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
hypest
added
the
Mobile App - i.e. Android or iOS
|
👋 @dcalhoun ! Added you as a reviewer since you have probably the best insight in the "new block" badge work. Let me know if the approach here makes sense to you, open to other approaches too. Thanks! |
dcalhoun
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the native mobile E2E "find block in inserter" method to account for newly available blocks too, since those have a slightly different accessibility ID.
After we bumped the mobile Editor Onboarding features to 100% rollout, some E2E tests started failing on
developof gutenberg-mobile due to the "newly available" marked blocks escaping the search methods.Related PRs
How has this been tested?
gutenberg-editor-search.test.jstestsTypes of changes
Update the
findBlockButton()method to search for both versions of the block name${ blockName } blockand${ blockName } block, newly available.Checklist:
*.native.jsfiles for terms that need renaming or removal).