-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gallery block undo issue #26377
Fix gallery block undo issue #26377
Conversation
Size Change: +20 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well!
The e2e test failure is unrelated to this PR, isn't it? We should be good to merge anyway? |
@tellthemachines Let me try a rebase, I know some tests have been fixed recently. |
0c90398
to
1c2b155
Compare
Hmm, that didn't go well, more failing than there was previously. I see there's a package-lock.json change so I'll have to commit that to master first (#26439). |
3c7c791
to
6dac7bb
Compare
6dac7bb
to
b4027ca
Compare
* Mark change in attributes when gallery mounts as not persistant * Fix typo
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <[email protected]> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Ella van Durpe <[email protected]> Co-authored-by: Adam Silverstein <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Marcus Kazmierczak <[email protected]> Co-authored-by: Addison Stavlo <[email protected]> Co-authored-by: O André <[email protected]>
Description
Fixes #26367
Part of #8119
When a gallery block is added it runs some logic to make sure the
linkTo
attribute is set correctly.This seems to cause an undo state which the user can't click past.
Elsewhere in the gallery block
__unstableMarkNextChangeAsNotPersistent
is used to prevent this, so I've used it again here.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: