Gallery - Only run the linkTo saving on the web since it's not mobile related #2736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed submodule gutenberg
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
guarani
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Approved via WordPress/gutenberg#26227 (review)
I'm not sure this is a [***], since it might not affect or be noticed by a large number of users (looking at internal reference pbMoDN-o4-p2), but I'm not certain of this, so feel free to leave as-is.
Sharp eye 😉 Downgraded in cd49644 |
|
Closing this PR as the issue was resolved in this one WordPress/gutenberg#26377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2735
Gutenberg PR WordPress/gutenberg#26227
The
linkTobehavior in the Gallery block was broken due to a recent set of changes which broke the undo functionality of the Gallery block. This occurred due to code being run on mobile that's related to the web so this PR fixes this issue so that the undo functionality of the Gallery block is restored.To test:
Follow the instructions in WordPress/gutenberg#26227
PR submission checklist: