-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Gallery - Only run the linkTo saving on the web since it's not mobile related #26227
[RNMobile] Gallery - Only run the linkTo saving on the web since it's not mobile related #26227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked on https://wordpress.org/gutenberg/ and I can reproduce this issue where I'm unable to undo the action of adding a Gallery block, so it isn't related to this PR. I don't see this issue reported: https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+undo+label%3A%22%5BBlock%5D+Gallery%22+ So I will go ahead and file a new issue for it. Could you please confirm @jd-alexander if you're able to reproduce this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since as noted in #26227 (comment), I confirmed that the issue where I'm unable to undo the action of adding a Gallery block is not caused by the changes in this PR.
Update: create #26367 to track this bug
Thanks @jd-alexander!
🙏
Thanks, I just checked and I was able to reproduce on the web as well. Super happy this bug was discovered.
No prob 🙏 |
Good work catching that! 👍 |
Fixes wordpress-mobile/gutenberg-mobile#2735
Description
#25582 introduced changes to utilize the
image_default_link_type
fromoptions.php
to set the default link for galleries.The issue is that the logic being utilized in the
useEffect
hook that triggers the saving of the link doesn't work with mobilegutenberg/packages/block-library/src/gallery/edit.js
Line 304 in 6f82c4b
So the current solution is to disable this on mobile and only run it on the web.
How has this been tested?
This has been tested using the instructions below.
Previously, the block wouldn't be removed.
Screenshots
Types of changes
Checklist: