Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Gallery - Only run the linkTo saving on the web since it's not mobile related #26227

Closed
wants to merge 3 commits into from
Closed

[RNMobile] Gallery - Only run the linkTo saving on the web since it's not mobile related #26227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3d2853
Only run the linkTo saving on the web since it's not mobile related.
jd-alexander Oct 16, 2020
5e80ad1
added platform logic to the existing if function in useEffect
jd-alexander Oct 22, 2020
7d5019b
Merge branch 'master' into rnmobile/fix_gallery_link_to_issue
jd-alexander Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ function GalleryEdit( props ) {
useEffect( () => {
// linkTo attribute must be saved so blocks don't break when changing
// image_default_link_type in options.php
if ( ! linkTo ) {
jd-alexander marked this conversation as resolved.
Show resolved Hide resolved
if ( Platform.OS === 'web' && ! linkTo ) {
setAttributes( {
linkTo:
window?.wp?.media?.view?.settings?.defaultProps?.link ||
Expand Down