Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Gallery block breaks the editor's undo button #26367

Closed
guarani opened this issue Oct 21, 2020 · 1 comment · Fixed by #26377
Closed

Adding a Gallery block breaks the editor's undo button #26367

guarani opened this issue Oct 21, 2020 · 1 comment · Fixed by #26377
Assignees
@talldan
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] History History, undo, redo, revisions, autosave. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@guarani
Copy link
Contributor

guarani commented Oct 21, 2020 •
edited by talldan
Loading

Describe the bug

Adding a Gallery block breaks the editor's undo button.

To reproduce
Steps to reproduce the behavior:

  1. Add a gallery block
  2. Try to use Undo

Expected behavior
Undo should revert the addition of the gallery block

Screenshots

gallery block not undone on web

Desktop (please complete the following information):

  • OS: macOS 10.15.6
  • Browser: Firefox
  • Version 81.0.2
@talldan talldan added [Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] History History, undo, redo, revisions, autosave. [Type] Bug An existing feature does not function as intended labels Oct 22, 2020
@talldan
Copy link
Contributor

talldan commented Oct 22, 2020

This seems like a pretty bad bug, so I've added it to the 5.6 Must Haves board.

@jd-alexander jd-alexander mentioned this issue Oct 22, 2020
Closed
6 tasks
@talldan talldan self-assigned this Oct 22, 2020
@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Oct 22, 2020
@talldan talldan mentioned this issue Oct 22, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] History History, undo, redo, revisions, autosave. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gallery block undo issue WordPress/gutenberg
2 participants
@talldan @guarani