Code block: preserve indentation on paste #26347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
ajitbohra,
cameronvoell,
etoledom,
guarani,
Soean,
talldan and
youknowriad
as code owners
|
Size Change: +40 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Backport to WP 6.7 Beta/RC
getdave
reviewed
Oct 21, 2020
| @@ -56,7 +57,12 @@ function filterInlineHTML( HTML ) { | |||
| HTML = removeInvalidHTML( HTML, getPhrasingContentSchema( 'paste' ), { | |||
| inline: true, | |||
| } ); | |||
| HTML = deepFilterHTML( HTML, [ htmlFormattingRemover, brRemover ] ); | |||
|
|
|||
| console.log( preserveWhiteSpace ); | |||
There was a problem hiding this comment.
Assume you want to ditch this?
There was a problem hiding this comment.
Yeah, sorry, had to push this quick
There was a problem hiding this comment.
Strange the linter didn't catch it
| } ) { | ||
| console.log( { preserveWhiteSpace } ); |
There was a problem hiding this comment.
We'll want to remove this.
ntsekouras
approved these changes
Oct 22, 2020
aristath
approved these changes
Oct 22, 2020
youknowriad
pushed a commit
that referenced
this pull request
Oct 22, 2020
tellthemachines
pushed a commit
that referenced
this pull request
Oct 26, 2020
6 tasks
tellthemachines
added a commit
that referenced
this pull request
Oct 27, 2020
* Fix drop zone indicators for non blocks (#25986) * Remove isDraggingBlocks check * Clean up drag and drop data if the user presses escape when dragging * Add comment to ensure avoidance of dragend * Switch to using dragend * Fix archives block render function (#26309) * Code block: preserve indentation on paste (#26347) * Turn off autocomplete for token input. (#26427) * Fix parent post selector: ensure initial value available, search performed, all results shown. (#26397) Co-authored-by: Nik Tsekouras <[email protected]> * [RNMobile] Fix CI issues during `npm ci` (#26455) * Run mobile tests on master * Debug CI * Revert "Debug CI" This reverts commit dec1ebe. * Update react-native-screens ref, pin @react-navigation/native version * Pin @react-navigation/core,router versions * Fix composer test failures due to invalid lock (#26472) * Fix gallery block undo issue (#26377) * Mark change in attributes when gallery mounts as not persistant * Fix typo * Fix package lock changes * Fix some Twenty Twenty One related e2e test failures (#26341) * Account for unknown number of controls in block inspector * Ensure selection is on-screen by using a group block instead of cover, which takes up less space on screen * Fix typewriter test * Use correct name for patterns test * Revert change to .wp-env.json * Fix multi-entity side editor saving test * Remove blank line * insert paragraph instead of tempalte part (#26371) * Fix autosave e2e tests (#26416) * Update how block to render is tracked (#26356) Co-authored-by: Daniel Richards <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: Ella van Durpe <[email protected]> Co-authored-by: Adam Silverstein <[email protected]> Co-authored-by: Nik Tsekouras <[email protected]> Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Marcus Kazmierczak <[email protected]> Co-authored-by: Addison Stavlo <[email protected]> Co-authored-by: O André <[email protected]>
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
This was referenced Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: