Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development to main #248

Closed
wants to merge 20 commits into from
Closed

Merge development to main #248

wants to merge 20 commits into from

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Apr 11, 2024

I thought we could merge this to main as a rebase or with a merge commit (i.e., not squash), then the history will be identical and retargeting the open PRs will be seamless.

lenkan and others added 19 commits February 13, 2024 21:42
fix sn to int parsing to use base 16
* fix: cannot set different salts for credential

* fix types

* add comments

* fix dt for issuance event
* URL enconding of name in api call

* prettier

* content-lenght header not needed

* add test

* remove debris

* fix test

* pretty

* Update test/app/aiding.test.ts
maybe fix upload issue
@pfeairheller
Copy link
Member

Seeing these integration tests break makes me think that a matrix of old KERIA versions probably doesn't make sense. New development is likely (especially at this stage) for breaking changes against new versions of KERIA.

@lenkan
Copy link
Collaborator Author

lenkan commented Apr 11, 2024

Hm yeah maybe that was a bit premature. But I think the tests that are failing is due to #244 , at least the from the sample of the logs I checked.

@lenkan
Copy link
Collaborator Author

lenkan commented Apr 11, 2024

@pfeairheller I added #249 that keeps the matrix, but only uses :latest for now. As you pointed out, currently there will be breaking changes that makes it difficult, but in the future it is easy to add the versions that is supported to the workflow and ensure compatibility.

@pfeairheller
Copy link
Member

New docker image and PyPi development release pushed at weboftrust/keria:0.2.0-dev0

@pfeairheller
Copy link
Member

@pfeairheller I added #249 that keeps the matrix, but only uses :latest for now. As you pointed out, currently there will be breaking changes that makes it difficult, but in the future it is easy to add the versions that is supported to the workflow and ensure compatibility.

I did not update the :latest tag on Docker because I think that should be a working version and not dev.

@lenkan
Copy link
Collaborator Author

lenkan commented Apr 11, 2024

Right. Then, we can use :latest for now, as specified in #249 (actually, 0.1.2 and 0.1.3 works for now as well). Then because both #241 and #234 requires the dev image, we can update it as part of one of those PRs, otherwise we will have failing tests I think until those are merged.

@lenkan lenkan marked this pull request as draft April 11, 2024 18:01
@lenkan
Copy link
Collaborator Author

lenkan commented Apr 11, 2024

On second thought - doing this as a PR seems to just add confusion with the Github action runs. At first I thought it would be good for visibility.

@lenkan lenkan closed this Apr 11, 2024
@pfeairheller
Copy link
Member

Yeah, good point. I tried a PR for the first merge like this in KERIpy and it was a mess. I just merge them because the action of doing so isn't really a PR but an expression of a bunch of other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants