-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge development to main #248
Conversation
fix: remove window.Buffer assignment
fix sn to int parsing to use base 16
chore: upgrade math.js
Signed-off-by: 2byrds <[email protected]>
* fix: cannot set different salts for credential * fix types * add comments * fix dt for issuance event
* URL enconding of name in api call * prettier * content-lenght header not needed * add test * remove debris * fix test * pretty * Update test/app/aiding.test.ts
Signed-off-by: Nuttawut Kongsuwan <[email protected]>
maybe fix upload issue
Seeing these integration tests break makes me think that a matrix of old KERIA versions probably doesn't make sense. New development is likely (especially at this stage) for breaking changes against new versions of KERIA. |
Hm yeah maybe that was a bit premature. But I think the tests that are failing is due to #244 , at least the from the sample of the logs I checked. |
@pfeairheller I added #249 that keeps the matrix, but only uses :latest for now. As you pointed out, currently there will be breaking changes that makes it difficult, but in the future it is easy to add the versions that is supported to the workflow and ensure compatibility. |
New docker image and PyPi development release pushed at weboftrust/keria:0.2.0-dev0 |
I did not update the :latest tag on Docker because I think that should be a working version and not dev. |
On second thought - doing this as a PR seems to just add confusion with the Github action runs. At first I thought it would be good for visibility. |
Yeah, good point. I tried a PR for the first merge like this in KERIpy and it was a mess. I just merge them because the action of doing so isn't really a PR but an expression of a bunch of other PRs. |
I thought we could merge this to main as a rebase or with a merge commit (i.e., not squash), then the history will be identical and retargeting the open PRs will be seamless.