fix: remove window.Buffer assignment #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we've had a polyfill setting
window.Buffer = import("buffer").Buffer
. However, window is not available in all environments (e.g. service workers). This causes background browser extension workers to either fail or require an extra polyfill.This PR fixes that by removing the polyfill and importing the module where it is needed instead.
There should be a way to ensure that the typescript build or eslint check fails if we are using APIs that are not available in both browser and node.js environment, but I haven't been able to figure it out yet.