fix sn to int parsing to use base 16

[lenkan]

The sequence number is expected to be a hex string without the preceeding 0x. So for example sequence number 10 is simply a. This causes issues with previous implementation because Number("a") => NaN this fixes the issue by specifying the base when parsing.

Another potential fix could have been to add a 0x prefix server side... But that probably has more implications that I am not aware of.

It would be good to add some unit tests that verifies the behaviour with a sequence number > 10.

There is a related issue where I wrote about this a few months ago: #138. Though I think the issue is broader than this particular fix. I simply searched the codebase for usage of the Number constructor and replaced them where it looked like it needed replacing.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cedee3a) 82.86% compared to head (9bae76d) 82.85%.

Files	Patch %	Lines
src/keri/core/number.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #216      +/-   ##
===============================================
- Coverage        82.86%   82.85%   -0.01%     
===============================================
  Files               47       47              
  Lines             4190     4189       -1     
  Branches          1044     1043       -1     
===============================================
- Hits              3472     3471       -1     
  Misses             689      689              
  Partials            29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kentbull]

I'm thinking this Number(sn) call likely also needs to be using parseInt(sn, 16).

[pfeairheller]

Good catch!

[pfeairheller]

Thanks for the new tests