Develop branch #771

Jym77 · 2021-04-20T14:36:50Z

Resolves #709, resolves #738, resolves #748, resolves #768, resolves #769, resolves #776, resolves #784, resolves #787, resolves #797, resolves #798, resolves #815, resolves #830

Add some tests for R3 (SIA R3: add test #792), R4 (SIA R4: Add test #793), R5 (SIA R5: add test #794), R6 (SIA R6: Added test #795), R8 (SIA-R8: Added tests #806), R11 (Add basic tests for R11 #770), R12 (SIA R12: Add Test #800), R17 (SIA R17: add test #791), R18 (R18 add test #803), R19 (SIA-R19: Add test #807), R42 (Extended diagnostic for R14 #786), background-size (Fix background size #788).
R62: removes second expectation, as it mostly causes false positives due to Security restrictions for the :visited pseudo-class are not accounted for #751 (Remove second expectation from R62 #772).
R62: accept differences in font-weight as good (dirty patch, need discussion) (SIA R62: accept different font weight #779).
Implement #equals and #toString for functional pseudo-classes and elements (Implement pseudo classes equality #773).
Accessible name: Skip step 1 of name computation when descending (Name computation: skip step 1 when descending #778).
R14: add extended diagnostic (Extended diagnostic for R14 #786).
R16: add extended diagnostic (R16 extended diagnostic #804).
R62: add extended diagnostic (R62 extended diagnostic #801).
background-size: accept percentages, accept 2 values, use Tuple to store value (Fix background size #788).
R66, R69: if a background has a background-size, do not try to resolve its colour and return cantTell; we need layout info to figure out if the background actually goes under the text or not (Assume no background on size #789).
Fix hasRole to use the role from the accessible node rather than Role.from() (Hasrole: use accessible node #805).
Support text-decoration-thickness (Support text-decoration-thickness #817)
Increase nodejs heap size in actions (was often running out of memory) (Trying to increase Nodejs heap size #818, Heap size problem and investigation. #822)
R65: accept difference in border as a valid focus indicator (SIA R65: accept different border as focus indicator #819)
Support font-variant and its longhands, plus font-variant-position (Support font-variant CSS property #821)
Implement R56 (Implement SIA R56 #829)
Remove whitespace only descendants from accessible name computation (Accessible name: reject whitespace descendants #831)

* Add toString() to Nth * Add equals() and toString() to functional pseudo-classes and elements

* Add failing example * Skip step 1 when descending

* Add failing example * Accept font weight difference with container as good for SIA-R62

* Add label and name in Diagnostic for R14 * Add tests for R42

* Add test cases for `background-size` * Accept percentages and two values for background-size * Use Tuple to store dimensions in background-size

* Bail out of background colour computation when encountering a background-size

* Create rule.spec.tsx * sia-r17 added test * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

* Sia r3 testing added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

…ing tests

* Test r5 added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * variable const target changed to html Co-authored-by: Jean-Yves Moyen <[email protected]>

* Pass tests for R12 implemented, starting with failed * Update rule.spec.tsx * Test rule 12 finished * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Text sintax improved Co-authored-by: Jean-Yves Moyen <[email protected]>

* Bump actions/create-release from 1 to 1.1.4 (#802) Bumps [actions/create-release](https://github.com/actions/create-release) from 1 to 1.1.4. - [Release notes](https://github.com/actions/create-release/releases) - [Commits](actions/create-release@v1...v1.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * SIA R18: Added test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]>

* Test for R19 Added * Added test for rule 19 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

* Added test to Rule 8 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

* Set role name in extended diagnostic * Required attributes added in rule and test * Extended diagnostic added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Correctly send required attributes to diagnostic * Structure diagnostic JSON a bit Co-authored-by: Jean-Yves Moyen <[email protected]>

* Expanded Diagnostic added for R62, test updated as well * Reduce computation in expected values * Clean up and streamline

* Remove duplicate test on border-style * Accept difference in border-* as focus indicator * Add some tests

* Double heap size

* Support font-variant-ligatures * Support font-variant-position * Support font-variant-caps * Support font-variant-numeric * Support font-variant-east-asian * Support font-variant * Support font-variant longhands in font shorthand * Add some test for font-variant

* Refactor normalize * Mark members of Group as readonly * Write R56 * Add extended diagnostic

* Add failing example * Ignore whitespace only descendants in name computation

packages/alfa-aria/src/role.ts

.github/workflows/integrate.yml

README.md

packages/alfa-rules/src/common/predicate/has-border.ts

packages/alfa-rules/src/sia-r56/rule.ts

packages/alfa-rules/src/sia-r62/rule.ts

packages/alfa-rules/test/sia-r11/rule.spec.tsx

packages/alfa-style/src/property/text-decoration-thickness.ts

Co-authored-by: Kasper Isager <[email protected]>

Changes made

kasperisager

See #771 (comment).

Forgot to push…

kasperisager

💯👏

* main: (43 commits) Update lockfile Update `normalize-url` Update README.md Add `archive` option in `Scraper#scrape()` (#840) Pass roles as part of diagnostics in SIA-R55 and SIA-R56 (#838) Update Node.js versions for workflows Fix listing of contrast ratios SIA R55: clean up unused imports (#836) Implement SIA-R55 (#835) Consider element with `height` or `width` of 0 as invisible unless the text overflows (#827) Formatting v0.19.0 Update changelog Develop branch (#771) v0.18.0 Update changelog Add missing annotations Deduplicate dependencies Update dependencies Bump browserslist from 4.16.3 to 4.16.6 (#814) ...

Add basic tests for R11 (#770)

a2c09e0

Jym77 self-assigned this Apr 20, 2021

Jym77 added 2 commits April 21, 2021 10:04

Remove second expectation from R62 (#772)

b3b3d06

Implement pseudo classes equality (#773)

53089a6

* Add toString() to Nth * Add equals() and toString() to functional pseudo-classes and elements

Jym77 added the major Backwards-incompatible change that touches public API label Apr 21, 2021

Jym77 and others added 24 commits April 27, 2021 14:50

Name computation: skip step 1 when descending (#778)

6aac6f4

* Add failing example * Skip step 1 when descending

SIA R62: accept different font weight (#779)

e6fb3bb

* Add failing example * Accept font weight difference with container as good for SIA-R62

Extended diagnostic for R14 (#786)

39be660

* Add label and name in Diagnostic for R14 * Add tests for R42

Fix background size (#788)

597c2a1

* Add test cases for `background-size` * Accept percentages and two values for background-size * Use Tuple to store dimensions in background-size

Assume no background on size (#789)

8b586a4

* Bail out of background colour computation when encountering a background-size

SIA R17: add test (#791)

62d1132

* Create rule.spec.tsx * sia-r17 added test * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

SIA R4: test added (#793)

a78c527

SIA R3: add test (#792)

69ea3cd

* Sia r3 testing added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

R6 test added (#795)

4f5fddd

Run prettier

b5f2dd6

Add --immutable flag to install instruction, add intructions for runn…

0c2977c

…ing tests

Simplify double negative

f66b35e

SIA R5: add test (#794)

6bc0448

* Test r5 added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * variable const target changed to html Co-authored-by: Jean-Yves Moyen <[email protected]>

Fix hasRole to pick the role from the accessible node (#805)

46eed6f

Merge branch 'main' into develop

39fbaad

Clean up

71d5482

SIA-R19: Add test (#807)

1a8b05b

* Test for R19 Added * Added test for rule 19 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

SIA-R8: Added tests (#806)

0378d6f

* Added test to Rule 8 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>

Clean up test descriptions a bit

6ec7b83

Use n-ary and to streamline code

e5950db

R62 extended diagnostic (#801)

0b0d863

* Expanded Diagnostic added for R62, test updated as well * Reduce computation in expected values * Clean up and streamline

Jym77 and others added 11 commits May 28, 2021 12:34

Merge branch 'main' into develop

24fa3fb

Remove unused imports

afd1c50

Increase Nodejs heap size (#818)

8f0338d

SIA R65: accept different border as focus indicator (#819)

3b282b6

* Remove duplicate test on border-style * Accept difference in border-* as focus indicator * Add some tests

Remove 'found' which is not used by frontend

dcecc1f

Fix serialisation of outline

a087aa5

Heap size problem and investigation. (#822)

da6a10f

* Double heap size

Test for SIA-R20 added

452bc78

Implement SIA R56 (#829)

b743bc9

* Refactor normalize * Mark members of Group as readonly * Write R56 * Add extended diagnostic

Accessible name: reject whitespace descendants (#831)

d73215b

* Add failing example * Ignore whitespace only descendants in name computation

Jym77 marked this pull request as ready for review June 11, 2021 10:01

Jym77 requested a review from kasperisager as a code owner June 11, 2021 10:01

kasperisager previously requested changes Jun 11, 2021

View reviewed changes

Jym77 and others added 4 commits June 11, 2021 15:17

Apply suggestions from code review

65c4c59

Co-authored-by: Kasper Isager <[email protected]>

Clean up formatting

56537b8

Replace Document.of by h.document

ce61ed6

Merge branch 'main' into develop

35441fa

Jym77 requested a review from kasperisager June 11, 2021 13:49

kasperisager previously requested changes Jun 11, 2021

View reviewed changes

Clean up README

f1bbf2a

Jym77 requested a review from kasperisager June 14, 2021 07:12

kasperisager approved these changes Jun 14, 2021

View reviewed changes

Jym77 merged commit bfb1a0d into main Jun 14, 2021

Jym77 deleted the develop branch June 14, 2021 08:55

Jym77 mentioned this pull request Jun 18, 2021

Implement SIA-R54 #834

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop branch #771

Develop branch #771

Jym77 commented Apr 20, 2021 •

edited

Loading

kasperisager left a comment

kasperisager left a comment

Develop branch #771

Develop branch #771

Conversation

Jym77 commented Apr 20, 2021 • edited Loading

kasperisager left a comment

Choose a reason for hiding this comment

kasperisager left a comment

Choose a reason for hiding this comment

Jym77 commented Apr 20, 2021 •

edited

Loading