Consider element with height or width of 0 as invisible unless the text overflows
#827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add toString() to Nth * Add equals() and toString() to functional pseudo-classes and elements
* Add failing example * Skip step 1 when descending
* Add failing example * Accept font weight difference with container as good for SIA-R62
* Add label and name in Diagnostic for R14 * Add tests for R42
* Add test cases for `background-size` * Accept percentages and two values for background-size * Use Tuple to store dimensions in background-size
* Bail out of background colour computation when encountering a background-size
* Create rule.spec.tsx * sia-r17 added test * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>
* Sia r3 testing added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>
* Test r5 added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * variable const target changed to html Co-authored-by: Jean-Yves Moyen <[email protected]>
* Pass tests for R12 implemented, starting with failed * Update rule.spec.tsx * Test rule 12 finished * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Text sintax improved Co-authored-by: Jean-Yves Moyen <[email protected]>
* Bump actions/create-release from 1 to 1.1.4 (#802) Bumps [actions/create-release](https://github.com/actions/create-release) from 1 to 1.1.4. - [Release notes](https://github.com/actions/create-release/releases) - [Commits](actions/create-release@v1...v1.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * SIA R18: Added test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]>
* Test for R19 Added * Added test for rule 19 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>
* Added test to Rule 8 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]>
* Set role name in extended diagnostic * Required attributes added in rule and test * Extended diagnostic added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Correctly send required attributes to diagnostic * Structure diagnostic JSON a bit Co-authored-by: Jean-Yves Moyen <[email protected]>
* Expanded Diagnostic added for R62, test updated as well * Reduce computation in expected values * Clean up and streamline
* Remove duplicate test on border-style * Accept difference in border-* as focus indicator * Add some tests
* Double heap size
* Support font-variant-ligatures * Support font-variant-position * Support font-variant-caps * Support font-variant-numeric * Support font-variant-east-asian * Support font-variant * Support font-variant longhands in font shorthand * Add some test for font-variant
Jym77
requested changes
Jun 8, 2021
Jym77
added
patch
Jym77
previously approved these changes
Jun 9, 2021
|
@Jym77 or @elenamongelli: Could one of you update the title to be a little more descriptive of what the changes involve? |
Jym77
changed the title
height or width of 0 as invisible unless the text overflows
kasperisager
approved these changes
Jun 16, 2021
kasperisager
added a commit
that referenced
this pull request
Jun 30, 2021
* main: (43 commits) Update lockfile Update `normalize-url` Update README.md Add `archive` option in `Scraper#scrape()` (#840) Pass roles as part of diagnostics in SIA-R55 and SIA-R56 (#838) Update Node.js versions for workflows Fix listing of contrast ratios SIA R55: clean up unused imports (#836) Implement SIA-R55 (#835) Consider element with `height` or `width` of 0 as invisible unless the text overflows (#827) Formatting v0.19.0 Update changelog Develop branch (#771) v0.18.0 Update changelog Add missing annotations Deduplicate dependencies Update dependencies Bump browserslist from 4.16.3 to 4.16.6 (#814) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #774